From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2559848-1516839274-2-8949772837181241062 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.25, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516839274; b=AOsVxlygvf5Kr2tB857ohTaRqjanjdP/zZQjdYzDEV/BmHC HogWrD2w56Irj/O+/jTuk6FVZ5EjBEdAtrflK8wVLAdaYirPaZEkD1Lt1AM0A0G+ pJbz/W0RHnF5w55KvXrCmWL1pWqdVq7n6A8ylV05HEsq6jg0Yi6p+FGSXBU94PAE 18mqtzyaJhavkJ6BmYRX9+9+fQ9FL/RqRQQGovjqub3zWkae3oprMnxGcRPlHbEG 5Uq9lWHyPSwV8LOPEPoWoHvNOXwUiyH6euoPmm4Obpc7Rf0vngzwv2gYd8plMLMB +OjVYkpjTNpYjCa77ljvT0O7/1KO2701nZS/TrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:references:from:message-id :date:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc :content-transfer-encoding:content-type:sender; s=arctest; t= 1516839274; bh=BSk/eR8HwbCzCIUlx11zvEYfIaHucFX6tTm6nl4JjLc=; b=H r4uHnLy4/QJrI9nQDnULVFl+5JU53Bxk4tFOa6/Efbk09bZIX1mjR9acEeKmWT/s SN9z/mYmzTqpH57JuV9dy+n3BCg3ZLwMp6ajhdUHfjuLNjQffpPjaTpOClXOwf2z Qk7loD8ic5jil10E4ObAoOVWhGbsV8qQi9f/3F3DIcsO4yX39M2PMYoais8+RAkb SYiMa/1qy/FdTNBDL/gjA5mQelTnXmEeGM7VBAVbXCUUTsyGDrZ7ldp64b9GoQpm tkHBj8ZL1jt0i6GhJdw5YjJLxTNp672oWniY9CaYJgb/3PMaWeKAeInN/IcKJKki lzTlsCxe9029sPqCXpVvg== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=puHTLfYG x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=kvnQ3TVJ; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=puHTLfYG x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=kvnQ3TVJ; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Google-Smtp-Source: AH8x226IFzq0G1a8j7kJnvjeOO7hSpT8Q2NZ+gA1wurbzuDlLx4TZrC/X3+ZUzBwwyrCe9MJJlmGbg== Subject: Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR To: "Gustavo A. R. Silva" , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Arnd Bergmann References: <20180124004340.GA25212@embeddedgus> From: Steve Longerbeam Message-ID: <5e53d6d8-d336-da37-fe12-0638904e1799@gmail.com> Date: Wed, 24 Jan 2018 16:14:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180124004340.GA25212@embeddedgus> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Acked-by: Steve Longerbeam On 01/23/2018 04:43 PM, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources. > The proper pointer to be passed as argument is ch. > > This issue was detected with the help of Coccinelle. > > Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/staging/media/imx/imx-media-vdic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx-media-vdic.c b/drivers/staging/media/imx/imx-media-vdic.c > index 433474d..ed35684 100644 > --- a/drivers/staging/media/imx/imx-media-vdic.c > +++ b/drivers/staging/media/imx/imx-media-vdic.c > @@ -177,7 +177,7 @@ static int vdic_get_ipu_resources(struct vdic_priv *priv) > priv->vdi_in_ch = ch; > > ch = ipu_idmac_get(priv->ipu, IPUV3_CHANNEL_MEM_VDI_NEXT); > - if (IS_ERR(priv->vdi_in_ch_n)) { > + if (IS_ERR(ch)) { > err_chan = IPUV3_CHANNEL_MEM_VDI_NEXT; > ret = PTR_ERR(ch); > goto out_err_chan; _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel