mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Niklas Cassel <niklas.cassel@axis.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>, Sekhar Nori <nsekhar@ti.com>,
	Cyrille Pitchen <cyrille.pitchen@free-electrons.com>,
	Niklas Cassel <niklass@axis.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	John Keeping <john@metanate.com>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] PCI: endpoint: Handle 64-bit BARs properly
Date: Fri, 9 Feb 2018 18:14:49 +0530	[thread overview]
Message-ID: <5e54c525-1b78-bef3-7f83-82eb872837da@ti.com> (raw)
In-Reply-To: <20180208215735.GD98765@bhelgaas-glaptop.roam.corp.google.com>

Hi Bjorn,

On Friday 09 February 2018 03:27 AM, Bjorn Helgaas wrote:
> On Thu, Feb 08, 2018 at 06:17:32PM +0530, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Thursday 08 February 2018 06:03 PM, Niklas Cassel wrote:
>>> A 64-bit BAR uses the succeeding BAR for the upper bits, therefore
>>> we cannot call pci_epc_set_bar() on a BAR that follows a 64-bit BAR.
>>>
>>> If pci_epc_set_bar() is called with flag PCI_BASE_ADDRESS_MEM_TYPE_64,
>>
>> Not related to $patch. But I have a query on when
>> PCI_BASE_ADDRESS_MEM_TYPE_64 should be set. Whether if the size is >
>> 4G or if the address can be mapped anywhere in the 64-bit PCIe
>> address space or both?
> 
> In general, PCI_BASE_ADDRESS_MEM_TYPE_64 should be set if the BAR is
> 64 bits wide.  IORESOURCE_MEM_64 is similar.

okay, if the HW support 64bit BAR, 64 bit flag should be set and not based on
size or anything else?

Thanks
Kishon

  reply	other threads:[~2018-02-09 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08 12:33 [PATCH v2 0/3] PCI endpoint 64-bit BAR fixes Niklas Cassel
2018-02-08 12:33 ` [PATCH v2 1/3] PCI: endpoint: Handle 64-bit BARs properly Niklas Cassel
2018-02-08 12:47   ` Kishon Vijay Abraham I
2018-02-08 15:18     ` Niklas Cassel
2018-02-08 21:57     ` Bjorn Helgaas
2018-02-09 12:44       ` Kishon Vijay Abraham I [this message]
2018-02-13 10:28         ` Lorenzo Pieralisi
2018-02-08 12:33 ` [PATCH v2 2/3] misc: pci_endpoint_test: " Niklas Cassel
2018-02-26 17:26   ` Lorenzo Pieralisi
2018-02-26 18:09     ` Bjorn Helgaas
2018-02-08 12:33 ` [PATCH v2 3/3] PCI: designware-ep: Return an error when requesting a too large BAR size Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e54c525-1b78-bef3-7f83-82eb872837da@ti.com \
    --to=kishon@ti.com \
    --cc=bhelgaas@google.com \
    --cc=cyrille.pitchen@free-electrons.com \
    --cc=helgaas@kernel.org \
    --cc=john@metanate.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=niklas.cassel@axis.com \
    --cc=niklass@axis.com \
    --cc=nsekhar@ti.com \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®