From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Qais Yousef <qyousef@layalina.io>
Cc: mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, yu.c.chen@intel.com,
dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
nysal@linux.ibm.com, aboorvad@linux.ibm.com,
srikar@linux.ibm.com, vschneid@redhat.com,
pierre.gondois@arm.com, morten.rasmussen@arm.com
Subject: Re: [PATCH v4 2/2] sched/fair: Use helper function to access rd->overutilized
Date: Mon, 4 Mar 2024 13:58:16 +0530 [thread overview]
Message-ID: <5e5c0a81-3c60-437c-b164-e1245222d964@linux.ibm.com> (raw)
In-Reply-To: <20240303185441.km7c4u7yui3b5nl2@airbuntu>
On 3/4/24 12:24 AM, Qais Yousef wrote:
> On 03/01/24 20:47, Shrikanth Hegde wrote:
>> Overutilized field is accessed directly in multiple places.
>> So it could use a helper function. That way one might be more
>> informed that it needs to be used only in case of EAS.
>>
>> No change in functionality intended.
>>
>> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
>
> Can we do the same for rd->overload too? A set_rd_overload_status() would be
> a nice addition too. Anyway.
We have some more experiments going around overload.
For example, currently it is writing sg_status & SG_OVERLOAD without checking if it has
changed first. On large systems that are not overloaded, that may help by reducing the
bus traffic.
I will pick up this after we have some more data on the above.
>
> Reviewed-by: Qais Yousef <qyousef@layalina.io>
>
Thank you.
>
> Thanks!
next prev parent reply other threads:[~2024-03-04 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:17 [PATCH v4 0/2] sched/fair: Limit access to overutilized Shrikanth Hegde
2024-03-01 15:17 ` [PATCH v4 1/2] sched/fair: Add EAS checks before updating overutilized Shrikanth Hegde
2024-03-03 18:50 ` Qais Yousef
2024-03-04 8:24 ` Shrikanth Hegde
2024-03-05 10:23 ` Qais Yousef
2024-03-05 14:56 ` Shrikanth Hegde
2024-03-01 15:17 ` [PATCH v4 2/2] sched/fair: Use helper function to access rd->overutilized Shrikanth Hegde
2024-03-03 18:54 ` Qais Yousef
2024-03-04 8:28 ` Shrikanth Hegde [this message]
2024-03-05 10:19 ` Qais Yousef
2024-03-05 14:05 ` Vincent Guittot
2024-03-05 15:03 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e5c0a81-3c60-437c-b164-e1245222d964@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=aboorvad@linux.ibm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=nysal@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=pierre.gondois@arm.com \
--cc=qyousef@layalina.io \
--cc=srikar@linux.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®