From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9C9C43331 for ; Thu, 7 Nov 2019 17:18:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24B322166E for ; Thu, 7 Nov 2019 17:18:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="HW/cS8KE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387414AbfKGRSe (ORCPT ); Thu, 7 Nov 2019 12:18:34 -0500 Received: from mout.web.de ([212.227.17.11]:39509 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729494AbfKGRSd (ORCPT ); Thu, 7 Nov 2019 12:18:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1573147098; bh=ZNw2cKTTPyc9vfPJkPsoHmlH3LWpf6arKv41vLwWhO0=; h=X-UI-Sender-Class:To:Cc:From:Subject:Date; b=HW/cS8KEW6Sib2Ks7taV4ZB82hlkkG2XGbl4vX2KMHAQcqf3sQ5mJ+QaC8MtbGoQd zImTGmajFWirZJfisMEcLqEtfpW0giebH9IXN0HkKRuDHi3018PJX4ugdgfYD8fcK6 NszqlIuS+CvtByOBE7+MW3ZDXodXTsw/q5VkwrIo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.48.68.124]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LrK0u-1hlywX3QJ2-0134F4; Thu, 07 Nov 2019 18:18:17 +0100 To: dri-devel@lists.freedesktop.org, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Anton Vasilyev , Daniel Vetter , David Airlie , Gerd Hoffmann Cc: LKML , kernel-janitors@vger.kernel.org, Dave Airlie , Kangjie Lu , Navid Emamdoost , Stephen McCamant From: Markus Elfring Subject: [PATCH] drm/qxl: Complete exception handling in qxl_device_init() Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <5e5ef9c4-4d85-3c93-cf28-42cfcb5b0649@web.de> Date: Thu, 7 Nov 2019 18:18:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:QNCvayIa51CvXcpM8g3+4HUCna6J+3crHOpWHAhYyxU83kh2Ayr Zkdr9I0ipFahhUdE+KCfiWX39URBtwQEruzWTmRgZYODBgHoqKY4tlggSsyMv3zGto2XRd2 lXVgCVEFPYlFS+bNKS1OzZwzm5F9JprX4ZxIaWlCCuEmj1kF+h84EbNdCJO2m7SiUOs/UmM VTT78geYLAIdL51ZeZOSw== X-UI-Out-Filterresults: notjunk:1;V03:K0:bZkdP7F1+M0=:HZUcAjZx0cU4Wb+4hA4krd slySVDLTygrlD71nmfDjuipjMNrJoD0UR1IGCajbLaMuc6+MUNyvyeIGGsEoXM37PU4S/lwLk 2svi/Qo+5jq21blhI+Jxfr6r/VxPKd79VtxUze5wkwEbvPF/T4g6YpgfKGYwVVtVuRKZXc26a VRUsNYximoWgbzL1JUqm96jyb/J1ZH/RLfhY1hvM16NdRbAA+lanfZJnIQukHr7gzGU6PcGlW 2SVZLkOtSAHkUTu8u5ozbmwhyiN1YOOpBDVaO+Ss03wkL5W67f6yMoDrd1hKTIf1+Shw2FI5x OgR+0ZRjO2dy/Fc6qt5Y+sMLV27eMOFmf9pEx3YC+bfJL/zlP3z12xRnmKYOl8/iQoWKHQZIc AurmktfTpe0+2v5azJMnDW2Z2xAtSRXuVY5rSCCwzzXmDnJ7YADIPrxH7RGmR1qJRm6l6CbuT nl/0uOMHLEbCDrUgHOsgZgAx5fgQuucsjzQ8i5y3blAfw0Y18ZRsxr0j2Iarf5QJokMH8EgP4 v8WWASs6YrwCxMSpnRV24q8Hb9/rJ8lez6/aY0tDSeSIHrx5dhAenRo1gBQdHJiRrriD7ugPd 7c7zVnYcGL5DO5DKAkCwABtDNJIOfOc/B+jpec5wmtp4Nag2XHv8HLSw4YJnwk/tDGbT3Yn/w AXqQAfC2D0/gp0eNseQs22SgQnNUB5VUhKFDLpQDygDXsgAsoG3Ih/oIhq1QCirZ7eCBgEj1m HGXs+eM/xxjd43RwPky+bXSV5q2ujmaXvCe/gCjgao0J2KbAjHf43Vzdgde5gDag3lIId08iE jmLnzCydJNM3bDhE3qy3lzs6bnzAVMZXs0ufnDKIKKhBv7DRYTZM8soUHixMDQfObH5S0zIyT LYe9sMi2d+nGNnsZcS9zuIvuf1iuqt2iXF7t9wzxIsqXfVxghJVQIYeYwfD6RtCr7pD0y/yJR YfKTuZ8MWf+z38F1b9/gfAJPgepXJFqqSz5Y8NhunSFxwliBa5tx4l90KumFr7rVgo07eliMs w3ujtzPA6xqFsRd3IsjJzncCQXkhY/BDdVJLcTqyJCgq/FmCw3/L7kfM0GjhUsOt/CqcXr5qc fuUCcLSVt5Z5xFDq9IWBb8wQ8QnX2AeVur+hsYxiC+46K6xmh6kPLrEUMlvLTjt5IbSa3kMSm FXmuMe59CKzrqQkSMdIRFv7S1AA5pmd9bZg/MTIW/TQvn0DLe0ZSIBciICFyauGU5+iiSPq5a Fa3H83tFbXpnV2CM8vz20ZXE7ISt0mOL69KGhXXknjZJ+gudcpodlKk2l56Q= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 7 Nov 2019 18:05:08 +0100 A coccicheck run provided information like the following. drivers/gpu/drm/qxl/qxl_kms.c:295:1-7: ERROR: missing iounmap; ioremap on line 178 and execution via conditional on line 185 Generated by: scripts/coccinelle/free/iounmap.cocci A jump target was specified in an if branch. The corresponding function call did not release the desired system resource then. Thus use the label =E2=80=9Crom_unmap=E2=80=9D instead to fix the exceptio= n handling for this function implementation. Fixes: 5043348a4969ae1661c008efe929abd0d76e3792 ("drm: qxl: Fix error hand= ling at qxl_device_init") Signed-off-by: Markus Elfring =2D-- drivers/gpu/drm/qxl/qxl_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index 611cbe7aee69..bfc1631093e9 100644 =2D-- a/drivers/gpu/drm/qxl/qxl_kms.c +++ b/drivers/gpu/drm/qxl/qxl_kms.c @@ -184,7 +184,7 @@ int qxl_device_init(struct qxl_device *qdev, if (!qxl_check_device(qdev)) { r =3D -ENODEV; - goto surface_mapping_free; + goto rom_unmap; } r =3D qxl_bo_init(qdev); =2D- 2.24.0