From: kuiliang Shi <seakeel@gmail.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>, alexs@kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org, sshegde@linux.ibm.com
Subject: Re: [PATCH v2 5/6] sched/fair: pack SD_ASYM_PACKING into sched_use_asym_prio
Date: Thu, 1 Feb 2024 16:45:23 +0800 [thread overview]
Message-ID: <5e60b86f-a854-4958-a936-820597d43b6b@gmail.com> (raw)
In-Reply-To: <20240201005547.GC18560@ranerica-svr.sc.intel.com>
On 2/1/24 8:55 AM, Ricardo Neri wrote:
> On Tue, Jan 30, 2024 at 09:17:07PM +0800, alexs@kernel.org wrote:
>> From: Alex Shi <alexs@kernel.org>
> pack SD_ASYM_PACKING into sched_use_asym_prio
>
> Instead of saying `pack` you could say "Check the SD_ASYM_PACKING flag
> in sched_use_asym_prio()"
>
>>
>> Then the flags check passed into sched_asym and sched_group_asym.
>> It's a code cleanup, no func changes.
>
> I'd the changelog as follows:
>
> "sched_use_asym_prio() checks whether CPU priorities should be used. It
> makes sense to check for the SD_ASYM_PACKING() inside the function.
> Since both sched_asym() and sched_group_asym() use sched_use_asym_prio(),
> remove the now superfluous checks for the flag in various places"
Thanks a lot for all comments for this series patches, will take your versions in all commits' logs.
Thanks!
Alex
next prev parent reply other threads:[~2024-02-01 8:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 13:17 [PATCH v2 1/6] sched/fair: add SD_CLUSTER in comments alexs
2024-01-30 13:17 ` [PATCH v2 2/6] sched/fair: remove unused parameters alexs
2024-01-30 13:17 ` [PATCH v2 3/6] sched/fair: cleanup sched_use_asym_prio alexs
2024-02-01 1:13 ` Ricardo Neri
2024-02-01 8:41 ` kuiliang Shi
2024-01-30 13:17 ` [PATCH v2 4/6] sched/fair: packing func sched_use_asym_prio/sched_asym_prefer alexs
2024-02-01 0:25 ` Ricardo Neri
2024-01-30 13:17 ` [PATCH v2 5/6] sched/fair: pack SD_ASYM_PACKING into sched_use_asym_prio alexs
2024-02-01 0:55 ` Ricardo Neri
2024-02-01 8:45 ` kuiliang Shi [this message]
2024-01-30 13:17 ` [PATCH v2 6/6 RFT] sched/fair: change sched asym checking condition alexs
2024-02-01 1:10 ` Ricardo Neri
2024-02-01 11:40 ` kuiliang Shi
2024-02-01 15:19 ` Shrikanth Hegde
2024-02-01 16:33 ` Ricardo Neri
2024-01-31 22:00 ` [PATCH v2 1/6] sched/fair: add SD_CLUSTER in comments Ricardo Neri
2024-02-01 8:58 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e60b86f-a854-4958-a936-820597d43b6b@gmail.com \
--to=seakeel@gmail.com \
--cc=alexs@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®