From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Chenyuan Yang <chenyuan0y@gmail.com>, <robdclark@gmail.com>,
<dmitry.baryshkov@linaro.org>, <sean@poorly.run>,
<marijn.suijten@somainline.org>, <airlied@gmail.com>,
<simona@ffwll.ch>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm/dpu: Fix error pointers in dpu_plane_virtual_atomic_check
Date: Tue, 8 Apr 2025 11:13:15 -0700 [thread overview]
Message-ID: <5e64069f-d93e-404f-a4f1-99f2ef101f5f@quicinc.com> (raw)
In-Reply-To: <20250314011004.663804-1-chenyuan0y@gmail.com>
On 3/13/2025 6:10 PM, Chenyuan Yang wrote:
> The function dpu_plane_virtual_atomic_check was dereferencing pointers
> returned by drm_atomic_get_plane_state without checking for errors. This
> could lead to undefined behavior if the function returns an error pointer.
>
> This commit adds checks using IS_ERR to ensure that plane_state is
> valid before dereferencing them.
>
> Similar to commit da29abe71e16
> ("drm/amd/display: Fix error pointers in amdgpu_dm_crtc_mem_type_changed").
>
> Fixes: 774bcfb73176 ("drm/msm/dpu: add support for virtual planes")
> Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
prev parent reply other threads:[~2025-04-08 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 1:10 Chenyuan Yang
2025-03-14 6:11 ` Dmitry Baryshkov
2025-04-08 18:13 ` Abhinav Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e64069f-d93e-404f-a4f1-99f2ef101f5f@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=chenyuan0y@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®