From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbdEAPnJ (ORCPT ); Mon, 1 May 2017 11:43:09 -0400 Received: from smtp-sh.infomaniak.ch ([128.65.195.4]:45837 "EHLO smtp-sh.infomaniak.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbdEAPnD (ORCPT ); Mon, 1 May 2017 11:43:03 -0400 Subject: Re: [PATCH v1] selftests: Make test_harness.h more generally available To: Will Drewry , Kees Cook References: <20170430122619.31407-1-mic@digikod.net> Cc: Shuah Khan , LKML , Andy Lutomirski , linux-kselftest@vger.kernel.org From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <5e655775-b2ec-3660-ae52-b7df7706db57@digikod.net> Date: Mon, 1 May 2017 17:11:29 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9UqPdmhqrKVnotRFc5v8HUhBuUgMT2x2d" X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.8 X-Antivirus-Code: 0x100000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9UqPdmhqrKVnotRFc5v8HUhBuUgMT2x2d Content-Type: multipart/mixed; boundary="Uq7dgLGv2QfhkN07DCjqUQrXa5cx6IjEs"; protected-headers="v1" From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= To: Will Drewry , Kees Cook Cc: Shuah Khan , LKML , Andy Lutomirski , linux-kselftest@vger.kernel.org Message-ID: <5e655775-b2ec-3660-ae52-b7df7706db57@digikod.net> Subject: Re: [PATCH v1] selftests: Make test_harness.h more generally available References: <20170430122619.31407-1-mic@digikod.net> In-Reply-To: --Uq7dgLGv2QfhkN07DCjqUQrXa5cx6IjEs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maybe an update on the MAINTAINERS file could help for future reviews? diff --git a/MAINTAINERS b/MAINTAINERS index c265a5fe4848..0361364afb50 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11254,6 +11254,7 @@ F: kernel/seccomp.c F: include/uapi/linux/seccomp.h F: include/linux/seccomp.h F: tools/testing/selftests/seccomp/* +F: tools/testing/selftests/test_harness.h K: \bsecure_computing K: \bTIF_SECCOMP\b On 30/04/2017 20:22, Will Drewry wrote: > On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook wro= te: >> >> On Sun, Apr 30, 2017 at 5:26 AM, Micka=C3=ABl Sala=C3=BCn wrote: >>> The seccomp/test_harness.h file contains useful helpers to build test= s. >>> Moving it to the selftest directory should benefit to other test >>> components. >> >> Unless Shuah thinks this should live in a new include/ directory, this= >> looks fine to me. >> >> Acked-by: Kees Cook >=20 > Same here! >=20 > Acked-by: Will Drewry >=20 >> >> Thanks! >> >> -Kees >> >>> >>> Signed-off-by: Micka=C3=ABl Sala=C3=BCn >>> Cc: Andy Lutomirski >>> Cc: Kees Cook >>> Cc: Shuah Khan >>> Cc: Will Drewry >>> Link: https://lkml.kernel.org/r/CAGXu5j+8CVz8vL51DRYXqOY=3Dxc3zuKFf=3D= PTENe88XYHzFYidUQ@mail.gmail.com >>> --- >>> tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- >>> tools/testing/selftests/{seccomp =3D> }/test_harness.h | 0 >>> 2 files changed, 1 insertion(+), 1 deletion(-) >>> rename tools/testing/selftests/{seccomp =3D> }/test_harness.h (100%)= >>> >>> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/te= sting/selftests/seccomp/seccomp_bpf.c >>> index 03f1fa495d74..d7095ff58e72 100644 >>> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c >>> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c >>> @@ -37,7 +37,7 @@ >>> #include >>> #include >>> >>> -#include "test_harness.h" >>> +#include "../test_harness.h" >>> >>> #ifndef PR_SET_PTRACER >>> # define PR_SET_PTRACER 0x59616d61 >>> diff --git a/tools/testing/selftests/seccomp/test_harness.h b/tools/t= esting/selftests/test_harness.h >>> similarity index 100% >>> rename from tools/testing/selftests/seccomp/test_harness.h >>> rename to tools/testing/selftests/test_harness.h >>> -- >>> 2.11.0 >>> >> >> >> >> -- >> Kees Cook >> Pixel Security >=20 --Uq7dgLGv2QfhkN07DCjqUQrXa5cx6IjEs-- --9UqPdmhqrKVnotRFc5v8HUhBuUgMT2x2d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUysCyY8er9Axt7hqIt7+33O9apUFAlkHUCUACgkQIt7+33O9 apUErQf7B1yKUolVGTRFV608tQwGYzEGmiegkskCHfvHj4gqx+g+9ddEFHPAFOzQ xv1QjSaxFqQLsGr03H3YsUHOdD59cv7glRh2m4lYEd9CFrm3A1LmUwWmme4EM7no T6Yd25E0ysdfM8vuRxITOtin1pm1g7LyZZqTLcyws3+VSaIatc5j3KEz506UY2nq fZUBHZHwGIAAd6Ol93RZMdFm6EVtGnOeesngng5gF4MFr6ZHOcm24C7dC8XqKWgv yl17wycHnW8UJNj34ANMLhgp2gBBQOSiR3ox2hIW2Czgzvo2tlGOEHRvd++5Xqrz uvdxKH2CaKiljxNivqk/b9JREMY8Bg== =aQR+ -----END PGP SIGNATURE----- --9UqPdmhqrKVnotRFc5v8HUhBuUgMT2x2d--