From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap5.colo.codethink.co.uk (imap5.colo.codethink.co.uk [78.40.148.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8E5F2DEA6B for ; Thu, 18 Jun 2026 08:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.40.148.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781769860; cv=none; b=CS0GZfwujUq2D2AZNQ4bLb8fQJPAa46KoCAdKbYX23h6xABFrGLHjJ7AS12rYW2m2GgLNJpXUprgAMYK/DTJdaTg0HORr3NiGG3BPsNbO7uZzOd5sZVhw4UIPBRYkHdG8gniLZzIsCaVxI1AOrOSzhir57UaKT6BlQTEv/4FChU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781769860; c=relaxed/simple; bh=jiXobjx59Kgly4aE72uOOh18Nt4WxF/3SiTzPu6dSSs=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=BECuBIpu85+cMxPfmvTxE98NY91JnykDIqkyowr7BF1fE44YxgX76nDGzeW98I3JFtX3D83pzME7LRfw3pPmitjIY2aJxpIDW8hYTbgUxnw3tXwPJeOj17UHJsKYVh8aK3NG9VLxZvrgUVxcA52OduUWMtAI+lRuBjE8/1abLms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.co.uk; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=DlOMLRml; arc=none smtp.client-ip=78.40.148.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="DlOMLRml" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap5-20230908; h=Sender:Content-Transfer-Encoding: Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date:MIME-Version: Reply-To; bh=Um0iholy7NtKIoOFnNm3rYwqCi6fDk16hVrlqiwRuKY=; b=DlOMLRmlGPJSv6iK jnYvyi9xgI4NIR5Byil9ZOGQpBsNIsgrl3AZdKL5XZCcRClC58gneGt5EQCZyIfA9iointgpDu/1B S+53xeEXmR1KOwv2H3YH7JgSDFbas1EFdDS0iNy2zUFBQYAVvKG9ihCx0AjU0xQ4fvN86eJheXUwj kR/JzA0LM/tuh3EDSuKYpzW8sZa1FLIPV4LIk5691qhST3Br4/Aq005Ru3vGwxyqfTkstGRuAvxct j/B7HbGlePImSwgfFvdPc4y7KC02fL33FDgVbQACsCOsOQAT9QMwvyvdEJy4Rl6yP0UosHMkt+uzx S0QbMvC1yaWZv+EYuA==; Received: from ipa12.colo.codethink.co.uk ([78.40.148.178] helo=webmail.codethink.co.uk) by imap5.colo.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1wa7jM-00Ex0d-82; Thu, 18 Jun 2026 09:04:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Thu, 18 Jun 2026 09:04:08 +0100 From: Ben Dooks To: Zi Yan Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: include for vm_numa_stat_key In-Reply-To: References: <20260617132726.1086576-1-ben.dooks@codethink.co.uk> Message-ID: <5e6b7e7ce7f9e2da70a73055eeec4157@codethink.co.uk> X-Sender: ben.dooks@codethink.co.uk Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Sender: ben.dooks@codethink.co.uk On 2026-06-17 16:47, Zi Yan wrote: > On 17 Jun 2026, at 9:27, Ben Dooks wrote: > >> The vm_numa_stat_key is declared in but this is >> currently not included in mm/page_alloc.c so include it to fix >> the following sparse warning: >> >> mm/page_alloc.c:165:1: warning: symbol 'vm_numa_stat_key' was not >> declared. Should it be static? >> >> Signed-off-by: Ben Dooks >> --- >> mm/page_alloc.c | 1 + >> 1 file changed, 1 insertion(+) >> > vmstat.h is already included at line 37[1]. > > I wonder why sparse complains and why adding a duplicated one below > fixes > it. I'll check, maybe the order is an issue here? > [1] https://elixir.bootlin.com/linux/v7.1/source/mm/page_alloc.c#L37 > > Best Regards, > Yan, Zi