From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE153339866 for ; Fri, 16 Jan 2026 15:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768575699; cv=none; b=ASTD+xHXJbwE38eLeZVNifArfVD2wgVh/xAevTkXj/dv+0r0S94794IO4CAZdJ6r51l/3jH3Oupw2H/tW1ynq4/9GlOSYA7IwuRZAzhQcVgBGyhUvYFaYvIxSZe4C4WcrqoF/CoZrBM6bH4gvtihDrGF+O+uAseZIjfTKSuA3kQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768575699; c=relaxed/simple; bh=Y5lS60MCep59cDqVjM2AufhfITG7cJG18eZ9uJyBoFg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RrNd8U+u/RD26H37QIjRlPZ+YCX1PUHjQrOyz2s32xm9mPeNBDlg+I8OtQndHltPVhb3D4GxKUSbnh8TEvFWJCvSQdubtK3/aR/BhZr6VMCBA/nY30TBk6cWvNPS6f2hxUiSHjx9Gv85ifiXHhy8jDPE/md/di2SoK89pOa9RKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YvW+yMPB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QJctBkpV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YvW+yMPB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QJctBkpV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768575696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rKg+lg08Z6N5Xk6F7Tf5pQeMj1OVmK93OUBlVqb40gM=; b=YvW+yMPBhl9TIAQfh+aZXk0Mb6SiUFq2sOPtYLeIntZUJggWk77OrV2Bxq8rpiDsDHvHM3 bgeC3XQa251W/UwfmPaWSdobZ76kJAYKGplIx/5y7WTCArfSpiy/yCMO8IDb11t8+PD8bx /PMGXy1gMciX/OB1TCw/NEtO11Y18XI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-LZMpSJWdP-iD20y-C0gg-Q-1; Fri, 16 Jan 2026 10:01:35 -0500 X-MC-Unique: LZMpSJWdP-iD20y-C0gg-Q-1 X-Mimecast-MFC-AGG-ID: LZMpSJWdP-iD20y-C0gg-Q_1768575694 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43101a351c7so1836751f8f.2 for ; Fri, 16 Jan 2026 07:01:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768575694; x=1769180494; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=rKg+lg08Z6N5Xk6F7Tf5pQeMj1OVmK93OUBlVqb40gM=; b=QJctBkpVv3yXTAUncCH28v5owqZSF/U5biiH9UZ9jxfqGI+a0gzLkaEydeTKQnCJ7b uwOxmNrvX4X9og3eUzeNpjtBJpDy+OjOAyXBkEVytRDg2a7zVHruDzGTEcl099+PoCpy yf0HhZkEaOewPvh/fU8h3DyubURSuEeD2HxjTxMsMEzi9CwKTM+AgGM+zjGTc3J+Y5Vt a/7BP1Ekjb65H9Eqbrlcfov4GmxOjeXZ1F4KfjP3lL/Z+t8G9y0ZGmHgU54viV5Oipa/ w9yb9w/IS9TDAhKvAe48TSgTNIc2yO6DMf2i64J5Pb7Is8ESgl5Dh4gYwaETmjmDGJnc fNnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768575694; x=1769180494; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rKg+lg08Z6N5Xk6F7Tf5pQeMj1OVmK93OUBlVqb40gM=; b=gWt6g5B6U81507Indg2PeHyM6fUvMUwyPEYqukdhZACSh93+jSVZoYYN+sxxyab+D8 s1X+o+rekpJNU59fsv42EbUwkjg/j0wuHceXHWOywmJjACpyyfBzo6MFlulVo33wVUYe 5ogtyoQPzKBXxnpaSZPghEc1THERypBp8Rh66voZd0Qfa/FvqsHH4oqyE6fHzpx+Y+H/ +92JnVXRtfaAv4xkxSGLNleHxxGbjbSl5gP0mUVt3yWyyLmvJThwpa1wUYxmDGGGNrub +QTlJ6a/aRH6xm5WRWHor8+hQfxtIGxUoxcoqKZk3UCcbhHhauW1E0jBU9t2qvVf3zFH pDaw== X-Forwarded-Encrypted: i=1; AJvYcCXeePLwbHBFvUuJZLRvpzoTPJUVloydIN7jIZ+I+V3nR8aoA8D+JmTyvUR61hLXGvAakvwwsgmKSACIjjc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/CP5JSFgrk0nGhPTvjeLLdaF1rGlulNb0TwhXqx1RlFAqZ2uO bq9puNtdFQsGmZoNKfpttiJ1DegGI4n1rMc7bo21u4WPedf0fb9xRKqYZbq0mAa3xGqXly1eyiQ sbBSZHlN2VhKda2HuIkxvTus7Q7v3rjrSPLrxorVI5KNPZbTQcOzlTvITfkW95FxEwzX4wmY8dl RC X-Gm-Gg: AY/fxX41XtxxrtLnHOK2sKjn8b5hYNal+RYn85y15BthoOg0zGhpYEnzohmwOzfDL2A GXmScAb6XQepBwHi/MEjtMFXJtms3MEt8K3HgtaJHQrrYkzMrNEHj8j4O8E+8sZuwGHvlXA+DnN sNMX8YmQKp9e0+TJDP2CCOZAmJ+pJU+XhDpsTyj0VSMnOMsnCFtye5QKE2hTb7C56mT/wUl0TJz Hws0PmIdY7zUfsHMGgSfKA6s9cg61nXzZvooYb0jZVu+1DP9Gx6/u6iAYITZaCnd3Y25Qnoj/m6 RdFW6qlmVD5yLLigAtf49+nSEcbf+XfD7gbjYdFFuxdwwYBpMpup1j0z7pUCSHa/QZ2IELmNmQD 4orezjup8VFbxFhuyMP77x+fM/rsw5USyANbdz+Jt5LThgqWT9xA5IE38WWgypC9vQF+2cSSH9u geCinIjDq1 X-Received: by 2002:a05:6000:2387:b0:430:fbad:687a with SMTP id ffacd0b85a97d-4356997f7bfmr4388989f8f.13.1768575694080; Fri, 16 Jan 2026 07:01:34 -0800 (PST) X-Received: by 2002:a05:6000:2387:b0:430:fbad:687a with SMTP id ffacd0b85a97d-4356997f7bfmr4388934f8f.13.1768575693570; Fri, 16 Jan 2026 07:01:33 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435699271dfsm5596932f8f.15.2026.01.16.07.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 07:01:33 -0800 (PST) Message-ID: <5e6c71ca24103a54c4909ae57e58544aec4a56be.camel@redhat.com> Subject: Re: [PATCH v4 10/15] sched: Add task enqueue/dequeue trace points From: Gabriele Monaco To: K Prateek Nayak Cc: Tomas Glozar , Clark Williams , John Kacur , linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , Juri Lelli , Masami Hiramatsu , Ingo Molnar , Peter Zijlstra , linux-trace-kernel@vger.kernel.org Date: Fri, 16 Jan 2026 16:01:30 +0100 In-Reply-To: <17f243a1-8977-4d52-aa26-d4556d62e12f@amd.com> References: <20260116123911.130300-1-gmonaco@redhat.com> <20260116123911.130300-11-gmonaco@redhat.com> <17f243a1-8977-4d52-aa26-d4556d62e12f@amd.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-01-16 at 20:20 +0530, K Prateek Nayak wrote: > Hello Gabriele, Nam, >=20 > On 1/16/2026 6:09 PM, Gabriele Monaco wrote: > > @@ -2087,6 +2087,8 @@ unsigned long get_wchan(struct task_struct *p) > > =C2=A0 > > =C2=A0void enqueue_task(struct rq *rq, struct task_struct *p, int flags= ) > > =C2=A0{ >=20 > For delayed task, I think you'll need: >=20 > if (trace_sched_enqueue_tp_enabled() && !(flags & ENQUEUE_DELAYED)) >=20 > > + trace_sched_enqueue_tp(p, rq->cpu); > > + > > =C2=A0 if (!(flags & ENQUEUE_NOCLOCK)) > > =C2=A0 update_rq_clock(rq); >=20 > Since delayed tasks haven't hit __block_task(), they are essentially > still enqueued. Peter should be able to confirm. Other than that, > the placements of the tracepoints look good now. Feel free to include: >=20 > Reviewed-by: K Prateek Nayak Mmh, I was sure I missed something after the comments on Nam's patch, thank= s for the heads up and review! Going to try your suggestion. Thanks, Gabriele