From: Brijesh Singh <brijesh.singh@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <brijesh.singh@amd.com>, <thomas.lendacky@amd.com>,
<herbert@gondor.apana.org.au>, <arnd@arndb.de>,
<lambert.quentin@gmail.com>, <gary.hook@amd.com>,
<linux-kernel@vger.kernel.org>, <Julia.Lawall@lip6.fr>,
<weiyongjun1@huawei.com>, <linux-crypto@vger.kernel.org>,
<umgwanakikbuti@gmail.com>
Subject: Re: [PATCH 1/2] crypto: move CCP device driver to misc
Date: Thu, 19 Jan 2017 13:10:54 -0600 [thread overview]
Message-ID: <5e6f9e9d-3a84-0aa4-d42a-c152fd75f884@amd.com> (raw)
In-Reply-To: <20170119181811.GA30851@kroah.com>
Hi Greg,
On 01/19/2017 12:18 PM, Greg KH wrote:
> On Thu, Jan 19, 2017 at 01:08:01PM -0500, Brijesh Singh wrote:
>> The CCP device is part of the AMD Secure Processor, which is not dedicated
>> solely to crypto. Move the CCP device driver to the misc directory in
>> prepration for expanding the usage of the AMD Secure Processor. Leaving the
>> CCP cryptographic layer (the ccp-crypto* files) in their current directory.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>> ---
>> drivers/crypto/Kconfig | 11
>> drivers/crypto/Makefile | 2
>> drivers/crypto/ccp/Kconfig | 21
>> drivers/crypto/ccp/Makefile | 9
>> drivers/crypto/ccp/ccp-dev-v3.c | 574 -----------
>> drivers/crypto/ccp/ccp-dev-v5.c | 1021 -------------------
>> drivers/crypto/ccp/ccp-dev.c | 588 -----------
>> drivers/crypto/ccp/ccp-dev.h | 647 ------------
>> drivers/crypto/ccp/ccp-dmaengine.c | 728 --------------
>> drivers/crypto/ccp/ccp-ops.c | 1876 -----------------------------------
>> drivers/crypto/ccp/ccp-pci.c | 354 -------
>> drivers/crypto/ccp/ccp-platform.c | 293 -----
>> drivers/misc/Kconfig | 1
>> drivers/misc/Makefile | 1
>> drivers/misc/amd-sp/Kconfig | 14
>> drivers/misc/amd-sp/Makefile | 8
>> drivers/misc/amd-sp/ccp-dev-v3.c | 574 +++++++++++
>> drivers/misc/amd-sp/ccp-dev-v5.c | 1021 +++++++++++++++++++
>> drivers/misc/amd-sp/ccp-dev.c | 588 +++++++++++
>> drivers/misc/amd-sp/ccp-dev.h | 647 ++++++++++++
>> drivers/misc/amd-sp/ccp-dmaengine.c | 728 ++++++++++++++
>> drivers/misc/amd-sp/ccp-ops.c | 1876 +++++++++++++++++++++++++++++++++++
>> drivers/misc/amd-sp/ccp-pci.c | 354 +++++++
>> drivers/misc/amd-sp/ccp-platform.c | 293 +++++
>> include/linux/ccp.h | 3
>> 25 files changed, 6111 insertions(+), 6121 deletions(-)
>> delete mode 100644 drivers/crypto/ccp/ccp-dev-v3.c
>> delete mode 100644 drivers/crypto/ccp/ccp-dev-v5.c
>> delete mode 100644 drivers/crypto/ccp/ccp-dev.c
>> delete mode 100644 drivers/crypto/ccp/ccp-dev.h
>> delete mode 100644 drivers/crypto/ccp/ccp-dmaengine.c
>> delete mode 100644 drivers/crypto/ccp/ccp-ops.c
>> delete mode 100644 drivers/crypto/ccp/ccp-pci.c
>> delete mode 100644 drivers/crypto/ccp/ccp-platform.c
>> create mode 100644 drivers/misc/amd-sp/Kconfig
>> create mode 100644 drivers/misc/amd-sp/Makefile
>> create mode 100644 drivers/misc/amd-sp/ccp-dev-v3.c
>> create mode 100644 drivers/misc/amd-sp/ccp-dev-v5.c
>> create mode 100644 drivers/misc/amd-sp/ccp-dev.c
>> create mode 100644 drivers/misc/amd-sp/ccp-dev.h
>> create mode 100644 drivers/misc/amd-sp/ccp-dmaengine.c
>> create mode 100644 drivers/misc/amd-sp/ccp-ops.c
>> create mode 100644 drivers/misc/amd-sp/ccp-pci.c
>> create mode 100644 drivers/misc/amd-sp/ccp-platform.c
>
> Please create your patch with -M, to show this is a rename, or a change
> with a rename. Otherwise this is an impossible patch to review, would
> you want to try to do it?
>
Thanks for the tip, will re-generate the patches with -M.
next prev parent reply other threads:[~2017-01-19 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 18:07 [PATCH 0/2] Introduce AMD Secure Processor device Brijesh Singh
2017-01-19 18:08 ` [PATCH 1/2] crypto: move CCP device driver to misc Brijesh Singh
2017-01-19 18:18 ` Greg KH
2017-01-19 19:10 ` Brijesh Singh [this message]
2017-01-20 16:33 ` kbuild test robot
2017-01-19 18:08 ` [PATCH 2/2] misc: amd-sp: introduce the AMD Secure Processor device Brijesh Singh
2017-01-19 18:22 ` Greg KH
2017-01-20 16:20 ` kbuild test robot
2017-01-20 19:51 ` kbuild test robot
2017-01-19 18:21 ` [PATCH 0/2] Introduce " Greg KH
2017-01-19 20:03 ` Brijesh Singh
2017-01-20 8:45 ` Greg KH
2017-01-20 15:40 ` Brijesh Singh
2017-01-20 17:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e6f9e9d-3a84-0aa4-d42a-c152fd75f884@amd.com \
--to=brijesh.singh@amd.com \
--cc=Julia.Lawall@lip6.fr \
--cc=arnd@arndb.de \
--cc=gary.hook@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=lambert.quentin@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=umgwanakikbuti@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®