mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Theodore Ts'o <tytso@mit.edu>, Jun Nie <jun.nie@linaro.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, Lee Jones <joneslee@google.com>
Subject: Re: [PATCH] ext4: reject 1k block fs on the first block of disk
Date: Wed, 22 Feb 2023 15:27:38 +0000	[thread overview]
Message-ID: <5e75fd39-3761-4402-1fa4-f4d2fac01ea4@linaro.org> (raw)
In-Reply-To: <Y+xgQklC81XCB+q4@mit.edu>

Hi!

On 2/15/23 04:32, Theodore Ts'o wrote:
> So if someone can explain to me what is going on here with this code
> (there are too many abstractions and what's going on with keys is just
> making my head hurt),*and*  what the change actually does, and how to
> reproduce the problem with a ***simple*** reproducer -- the syzbot
> mess doesn't count, that would be great.  But applying a change that I

I proposed a patch fixing this at:
https://lore.kernel.org/linux-ext4/20230222131211.3898066-1-tudor.ambarus@linaro.org/T/

Darrick proposed a similar one at:
https://lore.kernel.org/linux-ext4/Y+58NPTH7VNGgzdd@magnolia/

I explained the difference between the two in my cover letter.

Cheers,
ta

      parent reply	other threads:[~2023-02-22 15:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29  1:45 Jun Nie
2023-01-03 19:17 ` Darrick J. Wong
2023-01-04  1:58   ` Jun Nie
2023-02-15  4:32     ` Theodore Ts'o
2023-02-15 11:46       ` Tudor Ambarus
2023-02-15 11:53         ` Tudor Ambarus
2023-02-15 16:26           ` Tudor Ambarus
2023-02-22 15:27       ` Tudor Ambarus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e75fd39-3761-4402-1fa4-f4d2fac01ea4@linaro.org \
    --to=tudor.ambarus@linaro.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=djwong@kernel.org \
    --cc=joneslee@google.com \
    --cc=jun.nie@linaro.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®