From: "Chng, Jack Ping" <jack.ping.chng@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>, Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, mallikarjunax.reddy@linux.intel.com,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
"Kim, Cheol Yong" <cheol.yong.kim@intel.com>,
"Chng, Jack Ping" <jack.ping.chng@intel.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver
Date: Thu, 7 Nov 2019 17:47:58 +0800 [thread overview]
Message-ID: <5e7a5410-9797-817d-87c6-61dfce9df739@linux.intel.com> (raw)
In-Reply-To: <4D649A99D5D6C446954219080E51FB468192606D@BGSMSX103.gar.corp.intel.com>
On Mon, Nov 04, 2019 at 01:20:09PM +0100, Greg KH wrote:
>> On Mon, Nov 04, 2019 at 07:22:20PM +0800, Jack Ping CHNG wrote:
>>> This driver enables the Intel's LGM SoC GSWIP block.
>>> GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions.
>>> It allows CPUs and other accelerators connected to the SoC datapath
>>> to enqueue and dequeue packets through DMAs.
>>> Most configuration values are stored in tables such as Parsing and
>>> Classification Engine tables, Buffer Manager tables and Pseudo MAC
>>> tables.
>> Why is this being submitted to staging? What is wrong with the "real"
>> part of the kernel for this?
>>
>> Or even, what is wrong with the current driver?
>> drivers/net/dsa/lantiq_gswip.c?
GSWIP (a new HW IP) is part of Intel Datapath Architecture drivers
design for new Intel network/GW SoC (LGM).
Currently there are few other drivers (for different HW blocks in the
datapath) which are still under internal code review.
Once it is done we are planning to submit staging folder.
Since the development is ongoing, we thought it is best to submit GSWIP
first in drivers/staging/intel-dpa folder.
In the meantime, we will prepare a more detail TODO list for intel-dpa
folder and a README to introduce the dpa.
>> Jack, your patch does not seem to of made it to any of the lists. So i cannot comment on it contents. If this is a switch driver, please ensure you Cc: the usual suspects for switch drivers.
>>
>> Andrew
Sure, I will resubmit my patch.
Best regards,
Chng Jack Ping
next prev parent reply other threads:[~2019-11-07 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <03832ecb6a34876ef26a24910816f22694c0e325.1572863013.git.jack.ping.chng@intel.com>
2019-11-04 12:20 ` Greg KH
2019-11-04 16:42 ` Andrew Lunn
[not found] ` <4D649A99D5D6C446954219080E51FB468192606D@BGSMSX103.gar.corp.intel.com>
2019-11-07 9:47 ` Chng, Jack Ping [this message]
2019-11-04 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e7a5410-9797-817d-87c6-61dfce9df739@linux.intel.com \
--to=jack.ping.chng@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack.ping.chng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®