Re: Does it need to implement irq_set_type method in the ioapic_chip?

["H. Peter Anvin" <hpa@zytor.com>]

In the casee of your ACPI-enabled AMBA device I believe the BIOS, which provides the ACPI tables, is expected to set the interrupt type.

On February 19, 2014 4:07:09 AM PST, Thomas Gleixner <tglx@linutronix.de> wrote:
>On Wed, 19 Feb 2014, carl peng wrote:
>> At last, the device will be connected to AMBA bus, so the interrupt
>> pin will be connected to IOAPIC through AMBA bus. The device now
>> is in the pre-silicon verification stage.
>> 
>> So my question is the same:
>> Why does APIC driver not implement the irq_set_type method?  if
>
>Because we do not need it. All devices are properly connected and
>configured by the BIOS and bus discovery.
>
>> implement it, will supply more free space for the device driver
>> developer(they can set the interrupttrigger mode by calling
>request_irq).
>
>There are 3 different mechanisms already to tell the kernel to
>configure a particular irq line: ACPI, MP Tables and SFI.
>
>That's the way x86 does its interrupt configuration and there is no
>need to provide another one.
>
>Thanks,
>
>	tglx

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.