From: Andrew Lunn <andrew@lunn.ch>
To: netdev-bot+sashiko@kernel.org
Cc: kuangkai@kylinos.cn, netdev@vger.kernel.org, olteanv@gmail.com,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: user: document the write memory barrier on LAG conduit migration
Date: Tue, 10 Nov 2026 15:36:22 +0100 [thread overview]
Message-ID: <5e7d676a-9c02-409b-9312-57bae6c0be63@lunn.ch> (raw)
In-Reply-To: <179431548491.994134.1097968032701195124@kernel.org>
> [Severity: Medium]
> Can the wmb() in this position give the ordering the new comment
> describes?
Please consider which is better: No comment, or a wrong comment.
If you are adding comments, you need to be 100% sure they are correct.
wmb() and the like are not simple. Do you really understand what is
going on here? If you do, please respond to the LLM indicating how it
is wrong.
Andrew
next prev parent reply other threads:[~2026-11-10 14:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 12:56 [PATCH net-next 0/2] net: dsa: user: minor cleanups Kai Kuang
2026-10-28 12:56 ` [PATCH net-next 1/2] net: dsa: user: use kernel types in ethtool callbacks Kai Kuang
2026-10-28 13:00 ` Andrew Lunn
2026-11-09 12:06 ` [PATCH net-next 0/2] net: dsa: user: minor cleanups Kai Kuang
2026-11-09 12:06 ` [PATCH net-next 1/2] net: dsa: user: use kernel types in ethtool callbacks Kai Kuang
2026-11-09 12:06 ` [PATCH net-next 2/2] net: dsa: user: document the write memory barrier on LAG conduit migration Kai Kuang
2026-11-10 12:58 ` netdev-bot+sashiko
2026-11-10 14:36 ` Andrew Lunn [this message]
2026-10-28 12:56 ` Kai Kuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e7d676a-9c02-409b-9312-57bae6c0be63@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuangkai@kylinos.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®