From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DD8C2AE74; Wed, 19 Feb 2025 13:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739971830; cv=none; b=s/iwDl2FRW5y2BxKXrrWXu5LX/+slJLyXkiuq/v1uuRtkCRV2iJdelg+zr+av/gR/OfXoBqtQPUQkimakBJLAH9gM4kX4Hnd9HzLbqaj9cQhbBrpN7ayk3GcuduYfnnDGTLKL0rokAKcaUwsTYLxta2O3FPfBqAfIWUqgmkxb8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739971830; c=relaxed/simple; bh=O6x7SNy89g82HPWJGUfqA0X9THHPpDCJB2dBOG1XwF0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ydqw05YG5sW0pdFf3UHOCgC0B+dpiCh381bpc2bURHCPu8MorLbrtc6O5GYtPmqbAhion4JzVHEBquOY7XW7TeTY8uP5FT3926fBwZrcrFsZvlN6YnlX9P3/yx3cwFzfOTuOmsD/fzklqiA9QmpbrNw7fx32jil3WQuqcFQ56eM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=L+wa9Ip+; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="L+wa9Ip+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1739971826; bh=O6x7SNy89g82HPWJGUfqA0X9THHPpDCJB2dBOG1XwF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L+wa9Ip+3fVnUNZolzRaAGSL2sX+SgtItJw7JvBgQDuSf8T+1JlHglR7p0r/ZkpmC tJ6AfyICKKTVWd1I+tcnoDj1r7vGdpBq9C1Ho38SxrC21H4WYTHQJrOpoT0MDkJhqB tGOukiQF4+w0Eop1Qdg4pbhIN8dlOXpyEGrdXtW6gXh6h8mQzH7uZt70ZC60eJV7aj 9q0wuWAPXe962QypjHmLp0Rfy06a5ZJRJtQu0hZBEgCt5WUDmazZhedy44TGutYHsZ PjLg9xNBmjbKvKDaSTU2ZFCFqQJx/7vO5VQZ8rhi+isQMRdgIcERR4c3R1lUtlb4s5 yk1PE4ZQ29y5A== Received: from notapiano (unknown [IPv6:2804:14c:1a9:53ee::1000]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3DEBE17E1566; Wed, 19 Feb 2025 14:30:22 +0100 (CET) Date: Wed, 19 Feb 2025 10:30:19 -0300 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chen-Yu Tsai Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , kernel@collabora.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, parkeryang Subject: Re: [PATCH 6/6] arm64: dts: mediatek: mt8390-genio-common: Add routes for DMIC Message-ID: <5e7d7461-1af4-4e16-b808-072fe7c34e36@notapiano> References: <20250218-genio700-dmic-v1-0-6bc653da60f7@collabora.com> <20250218-genio700-dmic-v1-6-6bc653da60f7@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Feb 19, 2025 at 12:29:15PM +0800, Chen-Yu Tsai wrote: > On Wed, Feb 19, 2025 at 5:27 AM Nícolas F. R. A. Prado > wrote: > > > > Add necessary routes for the onboard dual DMIC present on the Genio > > 700/510 EVK. The dmic is supplied by micbias0 and micbias2, and inputs > > into the MT8188 DMIC DAI. > > > > Co-developed-by: parkeryang > > Signed-off-by: parkeryang > > Signed-off-by: Nícolas F. R. A. Prado > > --- > > arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi > > index a37cf102a6e928440cc88e7e8fe0225fc28ec962..efdeca88b8c4e58f0c17825156276babf19af145 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi > > @@ -959,7 +959,11 @@ &sound { > > pinctrl-0 = <&audio_default_pins>; > > audio-routing = > > "Headphone", "Headphone L", > > - "Headphone", "Headphone R"; > > + "Headphone", "Headphone R", > > + "DMIC_INPUT", "AP DMIC", > > + "AP DMIC", "AUDGLB", > > + "AP DMIC", "MIC_BIAS_0", > > + "AP DMIC", "MIC_BIAS_2"; > > mediatek,adsp = <&adsp>; > > status = "okay"; > > Shouldn't there also be one or two new dmic-codecs, and a dai-link here? The DMIC codec is only needed to get a wakeup delay and avoid an initial "pop" noise. Same as for the analog mic, for which I've recently sent a patch [1]. Depending on the order that things get picked up, I can either add the patch for it to this series, or the series in [1]. (Well, looks like I'll be sending a v2 for this series anyway, so I can add that patch here). Thanks, Nícolas [1] https://lore.kernel.org/all/20250214-genio700-amic-wakeup-delay-200ms-v1-1-0094837c62b7@collabora.com