From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D47C43217 for ; Wed, 16 Nov 2022 23:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbiKPX6n (ORCPT ); Wed, 16 Nov 2022 18:58:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbiKPX6j (ORCPT ); Wed, 16 Nov 2022 18:58:39 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67EBE12744 for ; Wed, 16 Nov 2022 15:58:37 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id o7so159683pjj.1 for ; Wed, 16 Nov 2022 15:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kojRkknuzQaruikj1Bw1AgCPwluH/lc+Fu21L+WOJJc=; b=RwvO8tezPJW+rHCmdRbQ+mADp1YnOCxf4exyMImXeZ746yvzytYOZgond8mRARU4tL pQ0qeYVAciS4yBF7nk1nbOofVyL4B0d4vDYyWLrCKCqfEo7QbjYmVUIae6tmOGUCGZRX fBpiXhZ1Dwi9HbTy3EYf8cIC4PNO85VbxGM3vhCGU8/Ag91kGCbRgGflI5IITZxfo1/2 ZJMk2wHlXJVUeD46A9eZFQaUKXVCSIiP4XB44lA7MDEobMur/ZeYiUenuLAulsMFYKz3 RbUnHNs3xlJr6g0xMtTRbBgwgAl36Yar5dWjaYRwWoPQqagB5508qtDcaTqP1yrdGiQQ E9lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kojRkknuzQaruikj1Bw1AgCPwluH/lc+Fu21L+WOJJc=; b=faoIFtehmV1L1klKIEL49X+4InbuUA/Q5GsWtg6BHhypsNWrPpskTHNHChb12hIojD Gsmnl73u2e3tiT5xhvhqi90aOBYXZcZHW4KJXW31yDYra2U9n4B7MF10du61Tu+oIAXn asTMQ3D+54jRyAVyDi/DFlsfxRESApAdfLONnFfKF0IF3ADx+VbFNbG+ypF/ufMXsIO9 lKB6nQORN6EHa31h08h0NYlmbTiZBcpRyhIgHNAbYIKVGNmSS/Pq66DFe1LANA7/jMH/ jeGSmvGSxI6aPjyzwpe5S+idcARUETK9OophDPlNiUEjy0EBC8zE96JSBiF2pBzDbST3 qa2w== X-Gm-Message-State: ANoB5pnexQlYGmAEOlsZp45qgPLc4+KCmcuQbyKx+6L8VkBhXjISnoL0 GAAryZC5B1hyTI/VzTzUcmzRlw== X-Google-Smtp-Source: AA0mqf6NGk2RuTo6aGaFr95auX8C3f+sgHmdR9BqJEXf7pgDbmWsgSj2ySTo9oGGDAcTDjfogAu8kQ== X-Received: by 2002:a17:90b:d13:b0:217:ecbd:5ae with SMTP id n19-20020a17090b0d1300b00217ecbd05aemr5831869pjz.17.1668643116857; Wed, 16 Nov 2022 15:58:36 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id nh9-20020a17090b364900b00212d9a06edcsm2173613pjb.42.2022.11.16.15.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 15:58:36 -0800 (PST) Message-ID: <5e885fce-a0b4-559f-5498-4402080f6a2e@kernel.dk> Date: Wed, 16 Nov 2022 16:58:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v10 0/3] blk-cgroup: Optimize blkcg_rstat_flush() Content-Language: en-US To: Waiman Long Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Lei , Andy Shevchenko , Andrew Morton , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Hillf Danton , Tejun Heo References: <20221105005902.407297-1-longman@redhat.com> <4b5142be-6a47-9dfd-a238-5b9d29b296b8@redhat.com> From: Jens Axboe In-Reply-To: <4b5142be-6a47-9dfd-a238-5b9d29b296b8@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/22 4:06 PM, Waiman Long wrote: > On 11/4/22 20:58, Waiman Long wrote: >> ? v10: >> ?? - Update patch 3 to rename the rstat function to >> ???? cgroup_rstat_css_cpu_flush(). >> >> ? v9: >> ?? - Remove patch "llist: Allow optional sentinel node terminated lockless >> ???? list" for now. This will be done as a follow-up patch. >> ?? - Add a new lqueued field to blkg_iostat_set to store the status of >> ???? whether lnode is in a lockless list. >> ?? - Add a new patch 3 to speed up the freeing of blkcg by flushing out >> ???? the rstat lockless lists at blkcg offline time. >> >> ? v8: >> ?? - Update the llist patch to make existing llist functions and macros >> ???? work for both NULL and sentinel terminated lockless list as much >> ???? as possible and leave only the initialization and removal functions >> ???? to have a sentinel terminated llist variants. >> >> This patch series improves blkcg_rstat_flush() performance by eliminating >> unnecessary blkg enumeration and flush operations for those blkg's and >> blkg_iostat_set's that haven't been updated since the last flush. >> >> Waiman Long (3): >> ?? blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path >> ?? blk-cgroup: Optimize blkcg_rstat_flush() >> ?? blk-cgroup: Flush stats at blkgs destruction path >> >> ? block/blk-cgroup.c???? | 103 +++++++++++++++++++++++++++++++++++------ >> ? block/blk-cgroup.h???? |? 10 ++++ >> ? include/linux/cgroup.h |?? 1 + >> ? kernel/cgroup/rstat.c? |? 20 ++++++++ >> ? 4 files changed, 119 insertions(+), 15 deletions(-) > > Jens, do you have any further comment on this patchset? Is it possible > to queue it for the next Linux version? Looks good to me, I'll queue it up. -- Jens Axboe