mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Schrefl <chrisi.schrefl@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Miguel Ojeda <ojeda@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Russell King" <linux@armlinux.org.uk>,
	"Rudraksha Gupta" <guptarud@gmail.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Geert Stappers" <stappers@stappers.nl>,
	"Jamie Cunliffe" <Jamie.Cunliffe@arm.com>,
	"Sven Van Asbroeck" <thesven73@gmail.com>,
	rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] arm: rust: Enable Rust support for ARMv7
Date: Fri, 31 Jan 2025 19:58:23 +0100	[thread overview]
Message-ID: <5e8a99a5-f39c-46da-b54d-7b69307b1c66@gmail.com> (raw)
In-Reply-To: <65da77f7-bbd4-4cbe-a06c-75f10a6ec4ce@lunn.ch>

On 31.01.25 5:05 PM, Andrew Lunn wrote:
>> To fix this Rust would have to provide a way to build the core
>> library without float support. I don't know if there is a plan
>> already to allow this.
> 
> Floating point is banned within the kernel, except for in very narrow
> conditions, because the floating point registers are lazy saved on
> context switch. If the kernel uses the floating point registers, you
> can break user space in bad ways.
> 
> I expect this has been discussed, since it is well known kernel
> restriction. Maybe go see what happened to that discussion within RfL?

After checking again, it seems the float intrinsics are actually not
needed anymore at least for my config. Only `__aeabi_uldivmod` is still
required for `parse_u64_into` since [0] allows disabling float formatting.

Link error without the `__aeabi_uldivmod` symbol defined:

ld.lld: error: undefined symbol: __aeabi_uldivmod
>>> referenced by num.rs:580 (/home/chrisi/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/fmt/num.rs:580)
>>>               rust/core.o:(core::fmt::num::parse_u64_into::<39>) in archive vmlinux.a
>>> referenced by num.rs:589 (/home/chrisi/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/fmt/num.rs:589)
>>>               rust/core.o:(core::fmt::num::parse_u64_into::<39>) in archive vmlinux.a
>>> referenced by num.rs:589 (/home/chrisi/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/fmt/num.rs:589)
>>>               rust/core.o:(core::fmt::num::parse_u64_into::<39>) in archive vmlinux.a
>>> referenced 34 more times
>>> did you mean: __aeabi_uidivmod
>>> defined in: vmlinux.a(arch/arm/lib/lib1funcs.o)

Not sure if we should just implement `__aeabi_uldivmod`, keep the 
panicking intrinsic for it or somehow fix it in upstream Rust?

Miguel do you know how this is best handled?

Link: https://github.com/rust-lang/rust/pull/86048 [0]

Cheers
Christian

  reply	other threads:[~2025-01-31 18:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 22:40 Christian Schrefl
2025-01-30 23:10 ` Christian Schrefl
2025-01-31  7:40 ` Arnd Bergmann
2025-01-31 15:34   ` Christian Schrefl
2025-01-31 16:05     ` Andrew Lunn
2025-01-31 18:58       ` Christian Schrefl [this message]
2025-01-31 19:37         ` Arnd Bergmann
2025-01-31 23:42           ` Christian Schrefl
2025-02-01  0:58             ` Christian Schrefl
2025-02-02 16:57           ` Christian Schrefl
2025-02-01  0:03         ` Christian Schrefl
2025-02-05 13:12       ` Miguel Ojeda
2025-02-05 13:14         ` Alice Ryhl
2025-04-06 14:59           ` Miguel Ojeda
2025-01-31 19:18     ` Arnd Bergmann
2025-03-21  7:24 ` Linus Walleij
2025-04-05 20:05   ` Christian Schrefl
2025-04-06 14:08     ` Manish Shakya
2025-04-06 14:57       ` Miguel Ojeda
2025-04-06 21:17         ` Benno Lossin
2025-04-06 21:31           ` Miguel Ojeda
2025-04-13 21:10   ` Christian Schrefl
2025-04-13 21:31   ` Christian Schrefl
2025-04-06 21:48 ` Manish Shakya
2025-04-07 16:04 Benno Lossin
2025-04-07 17:35 ` Miguel Ojeda
2025-04-07 23:03 ` Manish Shakya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e8a99a5-f39c-46da-b54d-7b69307b1c66@gmail.com \
    --to=chrisi.schrefl@gmail.com \
    --cc=Jamie.Cunliffe@arm.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=andrew@lunn.ch \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=corbet@lwn.net \
    --cc=gary@garyguo.net \
    --cc=guptarud@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stappers@stappers.nl \
    --cc=thesven73@gmail.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®