From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC802C08C5 for ; Wed, 3 Dec 2025 22:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764800347; cv=none; b=P73aWrpHih2/x9qg/YOMP+QgSRSObD6FDJzAG7eoFO/SE1+yORVNPnVgMhd50QsifxWhFhcZ0Jpc8j2HuowyHpTC1Fiuh9Bs0wRkv+BVqjT9FiFWolhm3vPFwpTIf/9pMQoH0uppaj36Ujk3swfJUGxHoQNbuDGEAhIxPbKTq2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764800347; c=relaxed/simple; bh=/A8SutLmf2Q2imzqCQUE3XZdtGNiq13pGzvVdsPO5K0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FkhZgVzB5SMGA5e3Q7X0XKA2mANnOkp/v/QPXubVY72Oxfv3Df8vPdh9IV4daCS6Msc7x1HsFOa9Ao+Bon5WFzXcpRB3NYeI7y/54LYwoBlpBLjayzglffI5gx073dPaVYCJlNgeBUiknSlPQFzmdGFcIWBvrO0pCuFLexgYrJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=zDWSnCz5; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="zDWSnCz5" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7c6d3676455so148655a34.2 for ; Wed, 03 Dec 2025 14:19:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764800343; x=1765405143; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hAPxaKKcC1USyEphOzVRjJP6Se/Bpb7jNM6YYf1MCzs=; b=zDWSnCz5Xjy76l1nV55htjmrTTjdCLtf4U9xfYVEo3fsKU50oXLmmS/uWEZmPwRWsk 2EN63Kj7RLJs4oPPWNWW+fusoRlTGug6zQLt1C+1N2vNmJf5Cus0QHOIku4/Kt1PA55O bSNaE1hlmY5OztExWha+KfCmzQhon010UU76vopoVBoICL/GREFNme+CAN3hyfT3Pit8 bqKwnGedK5jfgOOHsyf4UxkIvJXTs6CE7Kb3KXRrdC88sWjHz9U9J4oCy6Aquzjugw3l UVYmJ05FsumasAlL5p8cSC6xZyGCiS1VdqYONEV8AQ7UhII/l4qc8kY2h7fZ2ScLnLIB hYXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764800343; x=1765405143; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hAPxaKKcC1USyEphOzVRjJP6Se/Bpb7jNM6YYf1MCzs=; b=jMdLTWZvSPoLiHSZ0ZffzxfYwyNn0SxFRZLDFXGFU4NxKk1bqoh5cBHAOOnn5deRKx se7c6r599YriAdoD3g46CjtZruAPQ+/z7W4h1x+ixDFgovSPBWeSf7WoFDM6A8xDVIbo zepnayWy9XPqbJmi26Q2Zd6JcXadTEqSi9x5QYwf0TcTTBnRgZRyxr+/lioH/mICCeDc YTrC2E5SlynTiJdw3KTNOAukOMCnl/glQ4aLoiyiLcG8p25VpGjJP68QTFcNvBKGJKBA zQl0wEx+nNj9DFl6oWJNTW7jNfg+t+GJJgontCMD5FulQnUpn7GEh9Qr2+fwTUlkYPmB uNUw== X-Forwarded-Encrypted: i=1; AJvYcCWEm8zMhnhadD1xgbb8e8vqpj8r5IiUpJkbWNasqoobbxs99BHYLF9LO+Luxa2YN29543tslx4MLLSAK/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3ZX5Lyi21LDPB5MGv9dGrNnRE9cd38Dk0aPpp7+VQaKM+vfa7 GIn4ROaC8Pl/tF7Qhj2ypTCeHzV/Tcq3BbXL8VRrHMg0xEAIgYw4yAUOy2scmxz88AQ= X-Gm-Gg: ASbGncsRYnz8yyrANcHPSebrOz7IbKJ/VMGuzb5ywLoa2ClHGHMkwZbIS9463Om8e67 clmcRCious+HBrYA1vznWAhHoNsnKYIwN9OUwppHdxanJCdtmR088K93buSAzd9jl35RZyH7Ib0 McuN0eNfMf6dS7QUHfi/yp6+i/o5UnfGCGYD0Z2oBAFFbWzcs1PlnYwJYk37B3E6DeLQIOFGYsU zoAXU35KW0wC/VYTBOCpwlS8LE9JBDBMoYnojLB+MuwsP+s4sIvkXKObdt0MmOcHJjHN4f2oOFi GRwKWbRvbqyahJMy/yTBqBFToN6KZYQO12utOOQbHJwqzCKkbFc6fTpRIC9x0aanxyJ0YYqd7vm 3saR6z3+d7cDAqFGybq41GqMRM7nXOnL2z7rLcTG9AyBQhM1DrxbumrNrOnv9VMf0oC7gZJUDEm bLlRyK7L04ucsWxTYpSw== X-Google-Smtp-Source: AGHT+IF5slHx5Bd2B94CXXmhObw9UK5qoL62ZWpeXd1Z6+SRzywIRLzzipQNQCozh6c/1RDA7X0iAw== X-Received: by 2002:a05:6830:2b09:b0:7c7:6c4e:ad2 with SMTP id 46e09a7af769-7c94db3e9a7mr3598489a34.11.1764800343451; Wed, 03 Dec 2025 14:19:03 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:25f4:78dc:7b9e:e7a4? ([2600:8803:e7e4:500:25f4:78dc:7b9e:e7a4]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c90fe0f49esm9495223a34.22.2025.12.03.14.19.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 14:19:02 -0800 (PST) Message-ID: <5e8e3ff7-09e2-48c3-a9c4-cd7e5d6b850c@baylibre.com> Date: Wed, 3 Dec 2025 16:19:01 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 4/6] iio: light: vcnl4000: Use cleanup.h for IIO locks To: Kurt Borja , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Benson Leung , Antoniu Miclaus , Gwendal Grignou , Shrikant Raskar , Per-Daniel Olsson Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Guenter Roeck , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev References: <20251203-lock-impr-v1-0-b4a1fd639423@gmail.com> <20251203-lock-impr-v1-4-b4a1fd639423@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20251203-lock-impr-v1-4-b4a1fd639423@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/3/25 1:18 PM, Kurt Borja wrote: > Use ACQUIRE() for iio_device_claim_direct(). > > Signed-off-by: Kurt Borja > --- > drivers/iio/light/vcnl4000.c | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c > index 4dbb2294a843..55e5060ce337 100644 > --- a/drivers/iio/light/vcnl4000.c > +++ b/drivers/iio/light/vcnl4000.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1148,36 +1149,27 @@ static int vcnl4010_write_raw(struct iio_dev *indio_dev, > struct iio_chan_spec const *chan, > int val, int val2, long mask) > { > - int ret; > struct vcnl4000_data *data = iio_priv(indio_dev); > > - if (!iio_device_claim_direct(indio_dev)) > + ACQUIRE(iio_device_claim_direct, busy)(indio_dev); > + if (ACQUIRE_ERR(iio_device_claim_direct, &busy)) Calling the cleanup variable `busy` seems odd to me since if we successfully make the claim, busy will be non-null and therefore `if (busy)` would evaluate as true even though it wasn't "busy". I would call it `claim` to match iio_device_claim_direct().