From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC25F372B31 for ; Wed, 20 May 2026 18:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301372; cv=none; b=IXorHa+cZx1n4F+SScV2jAmJfcNQoZTDmantDljgbz4miDCqIiIdo5snjgR6LFtTLiNlYFVALD7iRKcSbJSau9as/DvmzQ1eXkOX6Pok7zg5Uf6J5o0wSMebcD1j1ko8r5AepMND/lm9b2fVkVJKXo87ma8XgZnL2TUN0c7NLxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301372; c=relaxed/simple; bh=+1DbRAYSjuddyF5jr/yEfLb6KnACKasLyU4fqXF0s4k=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=I9FDkpyvUk8KksTHWdRaxsOevO6/7mT1QJ/iAF2sbbBgJnn998KJdfky7UfQQP4F2753VKvm2qbtKXsrY2BgeCNRmLaBvK1u6mQtLeQyTSw0+YsHcGlvRqMpj2BMkDbK72/dJsQZClPsYAeA1ca2oMajzljU97lyRMvmfDtbLbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WfHga1FN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=T3BonLRs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WfHga1FN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="T3BonLRs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779301369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zWj+yOsSh8H863lqUCbXUEHFYFBatSqkhVNAfcgLZz8=; b=WfHga1FN2HgWG9u8GCbJLWtnWFf/NwyY5DmJ49CXXQjm3Y7WhPeC+K9be2f4eY/pzgepGW G081/wYVz3BkKuSNT9kL8zQBLX5lgOfMGdLQ8GSF7IRZojZZUJtwh8DkraS6srFOLmqllB pkG72LDqwDCC7/x/1e8P0oAgHo6Q7Gs= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-ESzGHxigMi-3W-mpPp4WrQ-1; Wed, 20 May 2026 14:22:48 -0400 X-MC-Unique: ESzGHxigMi-3W-mpPp4WrQ-1 X-Mimecast-MFC-AGG-ID: ESzGHxigMi-3W-mpPp4WrQ_1779301368 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-7d19c3a699fso11535147b3.2 for ; Wed, 20 May 2026 11:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779301368; x=1779906168; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=zWj+yOsSh8H863lqUCbXUEHFYFBatSqkhVNAfcgLZz8=; b=T3BonLRs9PIeDhIzVJYxaw5uj1LFYjYddB80inWLtyBqhUeBqcXiYASSMtgHvnv9TY woFBlClQ5He6I2uoex6xB9JJl3lcBvxpjeF3khCeSvxB2Tl55/wcck7JnlwEeZW398La itOJ706bWoDNJMqM9FWzj4pjDh545GiGh1hY/TOY7YiLcV+xxm7HtTuVX1MenknRVsXK Di+Z73G0a21Cjb4hhj7tXAcdqrLNE0oskVRMgw4gxR5wIDb992FicjtXgrhPrspb4K8p M9aazghVg5YXh3s6IzuWi56Dnc2goMNKA7u/QG5hjY1a6uWdz5RBa6IWiQZEAtmpjIuQ KHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779301368; x=1779906168; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zWj+yOsSh8H863lqUCbXUEHFYFBatSqkhVNAfcgLZz8=; b=QUJ5Fm9mIZsdZuLj+vEEMUnoTWrgmbjpAzifWn4jqCumFriSOPDBKtO9Yj/b0WlIY3 U9haCbvSGjThVarlBcb5gnodiS/E7P5QKEGvdEyLhv+JbgdSQ3neALwbx7tVKbfDMLDo 6GY4KymnwiwbypSHNmbW7qXg4W1dSnZUl5pCfWzgSa+dtHXK9WWZTFm6RCBb6yCPDv+2 nSRGSMpcOHDa6+tZzEX+9ZKULFE+orSGONScY/XNYq7uxQbGd4jkm11Fnt1QHej25OiU WsWYy5XaNU8dgT1YHaoQkhj6/PV1tp44z80V6FAhYiw9gVeb34+XCak69nORsiUFF+Bd Cv2Q== X-Forwarded-Encrypted: i=1; AFNElJ8L0UHOZlC409eS9TrYe4rHwtjUtLalg6RdXY+g1aqgGdhkYVXYCr3sOjTGkEHC4IpGqzVlZbB9wNisK7I=@vger.kernel.org X-Gm-Message-State: AOJu0YxyD9LHCb1TnaykU2vV52GmYtOjOj4AM23UyByawK9WWF6Pd9nx pw5AKLimG41jZyjYE8hPRjNNuoJeXGIyBG8gh8hyN7db4PR9ErvL8hYn6bNWnUz0+yh6ohw84Pw 3CBmwn269/sk7ZOJvaT083mesEZ1pQDyg+GXM/9tU8xUJjVuWSvLxGSzmUt/1OAJebQ== X-Gm-Gg: Acq92OHgA23GWoqZc5EfNxlgifec2JhKdONaj4UdUV9ajBgo0RZqI37FwvrZ7V8HqLN mnNow4PRTlKobf9pw1U04O5LsbogMhTfzPn/6W+PC6i6J97XQx3teqcsTV8FdG25G217Eg6cOVA TbVKtYeMH3MJUmhd5GjGh+PQdhvALsSh1cFZ8f9ufnfhuuGeXSuekZYg19keoMU/Dhhc7asWWVT GdIYRGZP1DSWtkK213oHdRxBgmMxuVCGgNOOiidd72IkE71PZ7ZMwwbq8pTLopkj3UqaJkJ4Bs1 5ffgMRVJ2sweqcsrK9xL1OOfRD463O4r7H1yEmb2EOV5E7qcMmOE2dn3WUU2/GD8H1OhPYdUkWA EpcLvq4oCxQjHjlSy+0qfyC7OlbgfjCl1N20AQMR/QHZX7Ovf5bhE X-Received: by 2002:a05:690c:660c:b0:7bd:a4dc:c25b with SMTP id 00721157ae682-7c95d1d6b5cmr262840387b3.40.1779301367598; Wed, 20 May 2026 11:22:47 -0700 (PDT) X-Received: by 2002:a05:690c:660c:b0:7bd:a4dc:c25b with SMTP id 00721157ae682-7c95d1d6b5cmr262840017b3.40.1779301366890; Wed, 20 May 2026 11:22:46 -0700 (PDT) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::29]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7cc997be36fsm57274807b3.16.2026.05.20.11.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 11:22:46 -0700 (PDT) Message-ID: <5e93451665b895d2d9088dacda79683e691e5219.camel@redhat.com> Subject: Re: [PATCH] nilfs2: Fix return in nilfs_mkdir From: Viacheslav Dubeyko To: Ryusuke Konishi , Viacheslav Dubeyko Cc: linux-nilfs , LKML , Hongling Zeng Date: Wed, 20 May 2026 11:22:45 -0700 In-Reply-To: <20260520101600.19734-1-konishi.ryusuke@gmail.com> References: <20260520101600.19734-1-konishi.ryusuke@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.0 (3.60.0-1.fc44app2) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-05-20 at 19:15 +0900, Ryusuke Konishi wrote: > From: Hongling Zeng >=20 > Return NULL instead of passing zero to ERR_PTR. > Fixes smatch warning: > - fs/nilfs2/namei.c:261 nilfs_mkdir() warn: passing zero to 'ERR_PTR= ' >=20 > Fixes: 88d5baf69082 ("Change inode_operations.mkdir to return struct dent= ry *") > Signed-off-by: Hongling Zeng > Signed-off-by: Ryusuke Konishi > --- > Hi Viacheslav, >=20 > Please add this to the queue for the next cycle. >=20 > This is one of the fixes by Hongling Zeng, a patch that individually > corrects a semantic issue (which is harmless in execution) related to > the use of the ERR_PTR macro that arose from a recent VFS change. >=20 > Thanks, > Ryusuke Konishi >=20 > fs/nilfs2/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c > index 40ac679ec56e..e2fe95de3d71 100644 > --- a/fs/nilfs2/namei.c > +++ b/fs/nilfs2/namei.c > @@ -258,7 +258,7 @@ static struct dentry *nilfs_mkdir(struct mnt_idmap *i= dmap, struct inode *dir, > else > nilfs_transaction_abort(dir->i_sb); > =20 > - return ERR_PTR(err); > + return err ? ERR_PTR(err) : NULL; > =20 > out_fail: > drop_nlink(inode); Applied. Thanks, Slava.