From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Adam Skladowski <a39.skl@gmail.com>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: interconnect: Add Qualcomm MSM8976 DT bindings
Date: Mon, 10 Jun 2024 14:50:41 +0200 [thread overview]
Message-ID: <5e980bfe-c939-478b-833e-d5816c3ed77f@linaro.org> (raw)
In-Reply-To: <20240609182112.13032-2-a39.skl@gmail.com>
On 09/06/2024 20:20, Adam Skladowski wrote:
> Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices.
>
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
A nit, subject: drop second/last, redundant "DT bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> ---
> .../bindings/interconnect/qcom,msm8976.yaml | 107 ++++++++++++++++++
> .../dt-bindings/interconnect/qcom,msm8976.h | 97 ++++++++++++++++
> 2 files changed, 204 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8976.yaml
> create mode 100644 include/dt-bindings/interconnect/qcom,msm8976.h
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8976.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8976.yaml
> new file mode 100644
> index 000000000000..bc9d08443e7c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8976.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,msm8976.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm MSM8976 Network-On-Chip interconnect
> +
> +maintainers:
> + - Konrad Dybcio <konradybcio@kernel.org>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The Qualcomm MSM8976 interconnect providers support adjusting the
> + bandwidth requirements between the various NoC fabrics.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,msm8976-bimc
> + - qcom,msm8976-pcnoc
> + - qcom,msm8976-snoc
> +
> + reg:
> + maxItems: 1
> +
> + clock-names:
> + minItems: 1
> + maxItems: 2
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
I know that other qcom bindings use that order (clock-names -> clocks),
but at least for new bindings let's keep it more logical, so please
first clocks then clock-names.
> +
> +patternProperties:
> + '^interconnect-[a-z0-9\-]+$':
> + type: object
> + $ref: qcom,rpm-common.yaml#
> + description:
> + The interconnect providers do not have a separate QoS register space,
> + but share parent's space.
> +
> + allOf:
> + - $ref: qcom,rpm-common.yaml#
Drop both lines.
> +
> + properties:
> + compatible:
> + const: qcom,msm8976-snoc-mm
> +
> + required:
> + - compatible
> +
> + unevaluatedProperties: false
Put it after $ref (before description).
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
This goes after entire allOf section
> +
> +allOf:
> + - $ref: qcom,rpm-common.yaml#
> + - if:
> + properties:
> + compatible:
> + const: qcom,msm8976-snoc
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: IPA clock from RPMCC
> + clock-names:
> + const: ipa
> +
> + required:
> + - clocks
> + - clock-names
Then why do you have two items? And what with clocks for other variants?
This is supposed to be fixed/specific for each device/variant.
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> + #include <dt-bindings/interconnect/qcom,rpm-icc.h>
> +
> + bimc: interconnect@400000 {
> + compatible = "qcom,msm8976-bimc";
> + reg = <0x00400000 0x62000>;
> + #interconnect-cells = <2>;
> + };
> +
> + pcnoc: interconnect@500000 {
> + compatible = "qcom,msm8976-pcnoc";
> + reg = <0x00500000 0x14000>;
> + #interconnect-cells = <2>;
> + };
Drop both nodes. The node below is enough as an example.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-10 12:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 18:20 [PATCH 0/7] msm8937/msm8976/qcs404 icc patches Adam Skladowski
2024-06-09 18:20 ` [PATCH 1/7] dt-bindings: interconnect: Add Qualcomm MSM8976 DT bindings Adam Skladowski
2024-06-10 12:50 ` Krzysztof Kozlowski [this message]
2024-06-09 18:20 ` [PATCH 2/7] interconnect: qcom: Add MSM8976 interconnect provider driver Adam Skladowski
2024-06-10 12:52 ` Krzysztof Kozlowski
2024-06-09 18:20 ` [PATCH 3/7] dt-bindings: interconnect: Add Qualcomm MSM8937 DT bindings Adam Skladowski
2024-06-10 12:53 ` Krzysztof Kozlowski
2024-06-09 18:20 ` [PATCH 4/7] interconnect: qcom: Add MSM8937 interconnect provider driver Adam Skladowski
2024-06-10 12:54 ` Krzysztof Kozlowski
2024-06-09 18:20 ` [PATCH 5/7] interconnect: qcom: qcs404: Introduce AP-owned nodes Adam Skladowski
2024-06-09 18:20 ` [PATCH 6/7] interconnect: qcom: qcs404: Add regmaps and more bus descriptions Adam Skladowski
2024-06-10 9:55 ` kernel test robot
2024-06-10 13:17 ` kernel test robot
2024-06-09 18:21 ` [PATCH 7/7] dt-bindings: interconnect: qcom: msm8939: Fix example Adam Skladowski
2024-06-10 12:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e980bfe-c939-478b-833e-d5816c3ed77f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®