From: Julian Stecklina <julian.stecklina@cyberus-technology.de>
To: Jani Nikula <jani.nikula@linux.intel.com>,
intel-gvt-dev@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, hang.yuan@intel.com,
dri-devel@lists.freedesktop.org, zhiyuan.lv@intel.com
Subject: Re: [PATCH 2/3] drm/i915/gvt: make gvt oblivious of kvmgt data structures
Date: Wed, 08 Jan 2020 18:08:28 +0200 [thread overview]
Message-ID: <5e98e9666bfeb275ec168df24bb8e9a33781229e.camel@cyberus-technology.de> (raw)
In-Reply-To: <87tv56qm9m.fsf@intel.com>
On Wed, 2020-01-08 at 12:24 +0200, Jani Nikula wrote:
> On Mon, 06 Jan 2020, Julian Stecklina <julian.stecklina@cyberus-technology.de>
> wrote:
[...]
> > + /* Hypervisor-specific device state. */
> > + void *vdev;
>
> I have no clue about the relative merits of the patch, but you can use
> the actual type for the pointer with a forward declaration. You don't
> need the definition for that.
>
> i.e.
>
> struct kvmgt_vdev;
> ...
> struct kvmgt_vdev *vdev;
The goal here is to make the GVT code independent of the hypervisor backend.
Different hypervisor backends need to keep different per-device state, so using
the KVM type here defeats the purpose.
I assume this is not only useful for us, but also for other hypervisor backends,
such as Xen or 3rd-party hypervisors.
Julian
next prev parent reply other threads:[~2020-01-08 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 14:06 [PATCH 1/3] drm/i915/gvt: fix file paths in documentation Julian Stecklina
2020-01-06 14:06 ` [PATCH 2/3] drm/i915/gvt: make gvt oblivious of kvmgt data structures Julian Stecklina
2020-01-08 10:24 ` Jani Nikula
2020-01-08 16:08 ` Julian Stecklina [this message]
2020-01-09 9:29 ` Jani Nikula
2020-01-06 14:06 ` [PATCH 3/3] drm/i915/gvt: remove unused vblank_done completion Julian Stecklina
2020-01-07 2:06 ` [PATCH 1/3] drm/i915/gvt: fix file paths in documentation Zhenyu Wang
2020-01-08 8:24 ` Julian Stecklina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e98e9666bfeb275ec168df24bb8e9a33781229e.camel@cyberus-technology.de \
--to=julian.stecklina@cyberus-technology.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hang.yuan@intel.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®