From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933590AbdBPVxx (ORCPT ); Thu, 16 Feb 2017 16:53:53 -0500 Received: from mail-by2nam01on0128.outbound.protection.outlook.com ([104.47.34.128]:49371 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933157AbdBPVxv (ORCPT ); Thu, 16 Feb 2017 16:53:51 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=abanman@hpe.com; Subject: Re: [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits To: Thomas Gleixner References: <1487123931-56809-1-git-send-email-abanman@hpe.com> <1487123931-56809-3-git-send-email-abanman@hpe.com> CC: , , , , , , , , Andrew Banman From: Andrew Banman Message-ID: <5ea08953-16b7-78db-0ce8-56dcf3b87bdf@hpe.com> Date: Thu, 16 Feb 2017 15:53:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.48.192.5] X-ClientProxiedBy: CY1PR1001CA0011.namprd10.prod.outlook.com (10.163.136.21) To AT5PR84MB0258.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.16) X-MS-Office365-Filtering-Correlation-Id: ccf9cd6c-2639-4fe5-f0d8-08d456b649b8 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:AT5PR84MB0258; X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0258;3:m6fTvg7NuUvth6fLNwRXL1NTnWOClPklL5PW5n0KeKa4cWjwJhwMRTLDq5HQiP1JWBGhQvzbB/TIOf48Kxx/QGYtxc6zxavjmbxWEOLRjZJBPCw/nr0fZNzBZLy/sV7oGZIU3PIVo901IWzb9LDQGa9eSUMXhto1NxYIwa7jRmbBzWnxFgkkqdL0EZKP1fIoec1CYUP+KeS9FOL6+GfwLz9s6RR7sYCIBnAP7s9FcuCc45AFThoKiYHfOv2F30IJDwEEB95A93T4++TjSXrk266EZYoHsfc/MY5ypGOL8uU=;25:QCXEYzlmDLMadrroytgiKZ1/9xdu9FuqUZ/9ph2jugfLnHtGsf3R8+zXZTvD/AlJcLHG0A3BIDinmRa7toJEcgMcBF3wOBIuoqvW/OKDsu0zD0Mp+t1k7uphJ2+X62OGwnwFiu5/+zrYJoaQEJejRoJu1LWsry6ye69jE8F8BrWxfAHJ9Soesc/oA2BMMzTEDv5mXf4poV/GgIfFV3aEIMZtX7jgdJY5VAsRHa/KdDNyUupdfGEgQkh37nd82FlfFqtHUVVL2rtLrqHLu4sXlAdfZYDIREYZ5pJQgCRR7TrVucDclehZrTAmBQSf/X77OSO+knaiLQqdyecnClxW6beb4p2pSPRxSW1tm/XOTnpHeoCfBHw0jRmiqRiO22UpNx+HQMZm/oEwlHC6nYcypfuoQNBmuXQMO+bCKnXppZMOxG4Gis5RMuCC5xVrGncJ+SNS4orBVAzd7OS/gSc0MQ== X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0258;31:EIgDjQ8qG+KEg3HiZ5TDd8KgDFSZJpbVRyTUtJb8FJRsvlCi4SJ6FSP5WUoBXdbTPFE8eqYdKr5ejFuFHx8FjSLqoLEO6VIHVO1meYljfEe4VaynMwfA3SMxavpzKx3zHluffAi+L3H/pYtRH6g99giK+TuUF6GPuQ8YQqsFDNnHKcUVB9EUV75UOHQpKdBh85c72BO3Ugi1wcjNBq6WnWK3jTZlXbHFzAC8fLHliO8=;20:Hj/8kh7cupRgUby6Wx2BPdUONCfIPEPu/eFp4mjAFCxLjllKBJIL4TKZkY4Z/Rml7W8qi9qv1jqZ1BulDxBOQIPaFG7iCKotxKACiwmHAyozIKj+cPrPpsbtNUX2IWc28v+rQU1f9HjKf0EMEYmJi8ehLa/j8gy2OWlFYawClWiy3o8TBHgIrd9WlKs40uAQ+6gJ9Noff5qOEmImtr6UICicCFCgQmGpCjUHP8UgeG+FpeVNP9GJ2pSCbkRptjLWpLz01KHnW4He53T+2wadcBZ1je2lsJnDzDajN0wyF+XoR3XNV7DcU/W2IUao/x3B0dgeBit+8RYSN8PvOsVXIFQ/cAfbNj0lv7Gg7E+o4kkRxb6TRJHr1IIYVnsqZYs2xMoLMNg6aH/W8Gnamb89ubTuPRyCPueMpzJb9y6om+P8LXx4lGZvm+EXMa2/tJ3yyU1mdGLBFPYiqfVAFJQaDpv82yr8LlLZkDzVllUjzN/tw2zXlfxWM2mBFCsx3YRg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123558025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:AT5PR84MB0258;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0258; X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0258;4:/SH2+edhwk0EvkGDSnPdzyb78qNoztDI7378HL8YgTdHWenT5no2PduipE+kKySA791AD0q6lyJ1gS8Z92leRtF2N2gCdcbiRH8iO+labIF3wemqgPTDJgjPwkFXLxCbRmNvwf2/Rq7yvh1iJbOE0JdMFVKvY4LhIDj/AAqFzrukIHdp1HmY0mA86uaPaEjtPpOUr0tMhTSnHMiDDqW9z3sRmMtbElgjk7QN8RhVTTi5OTD84llf/QYLge1q5QIXO62LijIbLgYZd2lo0uK4ufD5wsBcXJT3qVQtHynXf82tknBNw7ts5DotfSks5lJMjwTdcnAp24cPpeMSdlfvy8Pf8G6p2gutFVPVJhDr4MBH96BjykW3LKcNDxfAlq5PSN4brUHkUPiLfmjjmXTxTwikGhcvzlXl8ouuHdSbfvjvhhBcSTcyqckbUzLTyoL61KFZPaO4+7sAgbaP0HInG0imSd5EMr9Gk6gNh6eAqnFsvpkECs7WvXbF5O4wuuiWpAOgPS1DrHnGFZXm0VPgtFvVNYuZzsdpPlQgDqjuU1ITqRLKfzdJkQ57jovA6L3YrEFZJ9Qi8T9fN6bQY/YxwjIjQxVGMGeUORcBuAcXT/aJCVX0P83u6Eftp+WBM3v+ X-Forefront-PRVS: 0220D4B98D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39840400002)(39860400002)(39850400002)(39410400002)(39450400003)(199003)(377454003)(189002)(24454002)(68736007)(230700001)(229853002)(64126003)(53936002)(106356001)(105586002)(31686004)(31696002)(42186005)(92566002)(36756003)(53546006)(86362001)(6246003)(101416001)(189998001)(5660300001)(38730400002)(15650500001)(110136004)(65826007)(81166006)(97736004)(81156014)(54906002)(8676002)(6116002)(3846002)(47776003)(2950100002)(6916009)(6486002)(50466002)(4001350100001)(65956001)(65806001)(83506001)(66066001)(23746002)(50986999)(76176999)(33646002)(4326007)(2906002)(54356999)(305945005)(7736002)(389900003);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0258;H:[128.162.233.168];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AT5PR84MB0258;23:8ljFO6x1OScXkD+ROqI9Dua0ip6QqbBZJ191B?= =?Windows-1252?Q?fKBye7WPF9S7fmQpwDwvEH7Lr8KJYVbNnlKt0q0SlYHoxJkI5NDoKXcr?= =?Windows-1252?Q?rkSrHBR0e1ASXwIAs0O+2bicFeMGMQbUBw0Jn+SYeJb+clYPa5muzQWL?= =?Windows-1252?Q?vF4bdw0831gQ2/oOVaIuEomLsYFAzP7bAuRl146Zp/Q/leTfl2mK+nrS?= =?Windows-1252?Q?YCrfdInM91bMkxKQgo0kl3t3KUdlasZSMMFCCVVZN2egOgY6HWWrnM5b?= =?Windows-1252?Q?/jirstXVQdbbR0hR/TEWI1MRyxz7giczRtzANmFPdZHlh0iAkK8sFPOH?= =?Windows-1252?Q?ijQ6Ljd1apan8vB3KtrrccdzcbFTml9i+DRTCV8le7kAuEGwdJw3y6Os?= =?Windows-1252?Q?QmwVyFeuVPbPrnGuT8gRDcDh+F+36NzEm7v2NYnIWxvYeCoxTEKULtmV?= =?Windows-1252?Q?iRGpnoS2mYq7qS7xAhjqQPXJzQu73syo2WgYTmW0wv97Qwt82WLkhZ3V?= =?Windows-1252?Q?buTwKBy0c0M7UiGMd0uapSSllpd5IVl5+mfgqSj0ItriQd2QraAOvz+E?= =?Windows-1252?Q?FAj2kur/ZU3SHMbvYAi4Ojk9/QobwB2zcrCuKUstkHNN3yF8tlUipdSg?= =?Windows-1252?Q?LZqVUMU78mGG5IJCrxwsGqKIvIg0u8VEd6zE9RS1b1LVKsGBr8v/83qv?= =?Windows-1252?Q?S8o7JVMTybg7XSctWJxj21uOxj6u6Km9oxxZA9YdIKhUeQFDjLkJ1TGA?= =?Windows-1252?Q?AQhmMUqb7iRvKnuZSuWkJejx8jDAi8sZJS3z6Upjn/lHoRPrVSR8zgRW?= =?Windows-1252?Q?x19xRUJZ2HJEDMCaRIF27bMV6E+xT6SRbT6ceHDG3J8SsyfvNNCrl1P/?= =?Windows-1252?Q?d/cahvjaEkmw28x6dpwwJrLlHapCilday27DWd/GTDqK0AARwSTsa6sZ?= =?Windows-1252?Q?56+omExPwhg8qygChKuoV6+ePTuvSsyhACb1YQsp3IuIuUW5QAMwzFsn?= =?Windows-1252?Q?qsPwqB4S6fQ/fG4CbeelyVrGF21u6YYHLfUtKww8h/dQW9dNYL/AXFDR?= =?Windows-1252?Q?JVx1XVEwBdz0qdqj5rn5aKfMwT22pfJM1B73+P7OpKDW3SnRBC69fjMY?= =?Windows-1252?Q?A3jSdP9dvjwfhcG5knYnztBE02y5g9SX1NmdBJTdPfNkd1M6g0I0M/2w?= =?Windows-1252?Q?4vJAptsB81/cJc/J0ML4VEW4cB0vhOBj6kV9hwbmSEStAFAhF98piPAx?= =?Windows-1252?Q?ZypFP8G7EKusTYP4UxOgu9W46dJ9NJCj5wO5DyVvvcJA+XQS6/otyG1f?= =?Windows-1252?Q?auKsEaruaVf/UwiS01dJzZC41B9yj6VV0WmNqtCW9+3d8KV2y5rvSaOc?= =?Windows-1252?Q?P55Hc2W1o80kYpXRTlZv9AopB3hCEG/8PLQaTawdusT8j4Ty6l06ysxE?= =?Windows-1252?Q?Iy1IS6D8Jy5wQ10Wez1K1+cJ2bp0ZjJ/6vx3I5/EViAb6IZ8aXnk6g8s?= =?Windows-1252?Q?tJKSAxqF+Zb2SqOnAysB0mJeLXacOzDkpGoCK9wisHy4Stxq3P58Ed/t?= =?Windows-1252?Q?ghXlcnB0xsXy7QhDw5jGNYn1jWLDYYh0/JuBlDY2rBw2dqPGlKBO8qSX?= =?Windows-1252?Q?/qBsZ4TJ8a9o5U5BPsAz04=3D?= X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0258;6:lgvIJ4IqRoynj8zrvPTIiMB0pEvEoMBTs0uyvvFrevnn128f1XJSsn7QL5WBD1heHB0djnrjgSjegDmOHea8fxPphGApFa25vrby+FxJ7I7LTGsCnwFBjubKMgWYjazHYMyZpooVZl3j7Rn/SSOQ81MvsWYyeVO0wXuSw6hhxbHVXmjTcXIWBHTy+ZbvZTDbU4uUZluTeoHGBP4+LhtO+MlpIUgNgeZP3MMa2jxpg/pfmhD4sFsYZnUOlGF1nQ6MJRml8kKSIXRyQpIM9Gn/xpxEdfYixcx7T/P01x9WHbXkZh1UGTpzmJnA7PBE94OkirWyDAlsQB2QMch8rXEMpmyRH/xJY2eaDyoGxR72+CAc8/XFRCE/+W8BPI2q1zDHvwdPQ52CP9vbpl3mPofYESMUufCcosceUjqDqQnA26E=;5:V34iwuqh1clbv1zpsqS3f9vzVE3v2zTDVcl+1N7SvsUIdp2Zfy4lf4zA1hl0q0WPeJuq7aVIysyJ/WoGnDpc/gVERAbtN9vsFi05jRiQtaqDsf/II1HlV37IxzHUTL+k+qoQKokBRFdkmMvTu+3E9g==;24:Ug11mwNEHj+ViYu3Mjhv8ggHg4YM8rDkq/z3RS1nX9A7J80kdAa+6j1kg2sKGeMkPl3DK7BcQIBx2vog04O7E2tylvjO0DPEAZCL4XNwfuA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0258;7:zIF6fhYwx/McRW0qs1wOme/SPMMshfQOXly0f7odcKCp6PJc37DOKTVtqdsqeGGvALG9geWCooqvq92wvb9O4x7TDg1MJxVqRkX7nxQ34gHRR6zyjNIow70mTqEjcBi3GvHMu+ag8uemjmTqjLVsS4Of/Sat/SUZH93MUUJ8x8HGDLOdtYTnenMgH6AHo3zmK5NYGDDYAnVVN9wgzhVecbcfJ3Mp9MeBRwdiyw9hojsEs7VSkypKpzxUiO34UaVlQ0XqOkglmvsy0M2enVEhJqps8eAQn+i7ynEYQhucU7vpPWhbhqubeOJxYFAvDd2TbQVSIRMpAhNRfavv6izRAA== X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2017 21:53:47.6376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0258 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2017 12:07 PM, Thomas Gleixner wrote: > On Tue, 14 Feb 2017, Andrew Banman wrote: > >> The location of the ERROR and BUSY status bits depends on the descriptor >> index, i.e. the CPU, of the message. We determine this location ahead of >> the wait_completion loop to avoid repeating the calculation. >> >> Split out the status location calculation into a new routine, >> status_mmr_loc, to be used within each uv*_wait_completion routine. > > And the reason for this is? You just tell WHAT you are doing, not the WHY. > > Looking at the patch which implements the uv4 wait function it uses the > thing as well. So for the casual reader there is no point. > > The only reason i figured why you want to do that is to reduce the number > of arguments to the wait function, correct? > > If yes, then spell it out. If no, please enlighten me. Yes, the purpose was to re-scope the mmr location-finding logic into the uv*_wait_completion routines to make the call to wait_completion less complicated. Though, on second thought, the *mmr and *index values in status_mmr_loc should really be set during initialization because they do not change. The calculation is always done with desc=uvhub_cpu. I would add status_mmr and status_index to struct bau_control and move the calculation to scan_sock; there's no need for a subroutine in this case. Thanks, Andrew Banman > > Thanks, > > tglx >