From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B1CE12C534 for ; Wed, 24 Jun 2026 13:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782308550; cv=none; b=gjOiemC4ezpVadk2hdKsqGBxdLFJnavGY+Rc7WZ8m3h+ol4CODRN5+H3P4IeXyPedESDdhVi2oUQrMChwkWyaMf8l+l7wLwXREQAv9yYKDoE3FoEdVRai37X1UAdznxCRnMxydRNbkeSQXrVuNnz15bJq9VGKM/jmCwCCUXALmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782308550; c=relaxed/simple; bh=sPYXVdR3XnU5XF2+0KTe8yRvENoikdkGxTLyDDn6oHI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=O5LL4+MTIXewxOd8KInzqPDgXnZf/mxLqzcF4S1qJQYrNz7vHyXCMhKvFKF408/cUsFX6zx3A4/zw34BiAM9KzJ8bkx44vS+Zr6aCi6l0OzuYDF/M/Y2naT3C36wFFFlwaGLB0L9ZJQGYK+udBDIKgp9RMVn6/9sDqMHilVeDEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=ZY2U6+AF; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="ZY2U6+AF" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB25E2576; Wed, 24 Jun 2026 06:42:22 -0700 (PDT) Received: from [10.2.213.11] (e137867.arm.com [10.2.213.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 039463F58B; Wed, 24 Jun 2026 06:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782308547; bh=sPYXVdR3XnU5XF2+0KTe8yRvENoikdkGxTLyDDn6oHI=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From; b=ZY2U6+AFT/Y2egQCwd/2qzms+gYMyAGh0OqywJMpFhBW5+iJjb3qgWLeVc4vb1Rsv QUZy5tIIPWv5RTprTgatLSnZdlJ/1QQFtpuiNOrZpLw8end3xzc9yuejSYBz+53GVN j/OvxZNJqyULLcCBdZPkyYa+tN6/CDhJoc5C6cDE= Message-ID: <5ea376d7-388a-418c-acde-9ebe1da96202@arm.com> Date: Wed, 24 Jun 2026 14:42:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 03/11] arm64/ptrace: Use syscall_get_nr() helper for syscall_trace_enter() To: Jinjie Ruan References: <20260511092103.1974980-1-ruanjinjie@huawei.com> <20260511092103.1974980-4-ruanjinjie@huawei.com> From: Ada Couprie Diaz Cc: Ada Couprie Diaz , catalin.marinas@arm.com, will@kernel.org, oleg@redhat.com, tglx@kernel.org, peterz@infradead.org, luto@kernel.org, kees@kernel.org, wad@chromium.org, mark.rutland@arm.com, yeoreum.yun@arm.com, linusw@kernel.org, kevin.brodsky@arm.com, ldv@strace.io, thuth@redhat.com, james.morse@arm.com, song@kernel.org, anshuman.khandual@arm.com, broonie@kernel.org, ryan.roberts@arm.com, pengcan@kylinos.cn, liqiang01@kylinos.cn, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Language: en-US, en-GB, fr Organization: Arm Ltd. In-Reply-To: <20260511092103.1974980-4-ruanjinjie@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/05/2026 10:20, Jinjie Ruan wrote: > Use syscall_get_nr() to get syscall number for syscall_trace_enter(). > This aligns arm64's internal tracing logic with the generic > entry framework. > > [Changes] > 1. Use syscall_get_nr() helper: > - Replace direct regs->syscallno access with > syscall_get_nr(current, regs). > - This helper is functionally equivalent to direct access on arm64. > > 2. Re-read syscall number after tracepoint: > - Re-fetch the syscall number after trace_sys_enter() as it may have > been modified by BPF or ftrace probes, matching generic entry behavior. > > [Why this matters] > - Aligns arm64 with the generic entry interface. > - Makes future migration to generic entry framework. This is missing what it makes the future migration . Easier, possible ? (Same in patch 02, but I missed it !) > - Properly handles syscall number modifications by tracers. > - Uses standard architecture-independent helpers. > > No functional changes intended. > > Cc: Mark Rutland > Cc: Will Deacon > Cc: Catalin Marinas > Reviewed-by: Linus Walleij > Reviewed-by: Yeoreum Yun > Reviewed-by: Kevin Brodsky > Signed-off-by: Jinjie Ruan > --- Otherwise, Reviewed-by: Ada Couprie Diaz