From: Philipp Zabel <p.zabel@pengutronix.de>
To: John Crispin <john@phrozen.org>, Stefan Roese <sr@denx.de>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
devicetree@vger.kernel.org, lei.dong@airoha.com,
Linqi.zhang@airoha.com, linux-arm-kernel@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, Rajeev.kumar@airoha.com,
upstream@airoha.com, Weifeng.xu@airoha.com,
zhengping.zhang@airoha.com
Subject: Re: [PATCH v2 1/3] i2c: mt7621: assert and deassert the reset line
Date: Mon, 16 Nov 2026 10:58:11 +0100 [thread overview]
Message-ID: <5ea675380093047ea19951a31005e3c1e5ca0e04.camel@pengutronix.de> (raw)
In-Reply-To: <20261112185820.1315718-2-john@phrozen.org>
On Do, 2026-11-12 at 19:58 +0100, John Crispin wrote:
> The driver resets the controller with device_reset(), which needs a
> .reset operation in the reset controller. The EN7581 reset controller
> implements assert and deassert only, so there every call fails, logs
> "I2C reset failed!" and leaves the controller as it is, also after a
> transfer timeout.
>
> Get the optional reset line at probe and assert and deassert it. The
> MT7621 and MT7628 reset controller does the same in its .reset
> operation, with no delay in between, so nothing changes there. A board
> without a reset line no longer logs an error, and a reset controller
> that is not ready yet defers the probe.
>
> Suggested-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: John Crispin <john@phrozen.org>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2026-11-16 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 18:58 [PATCH v2 0/3] i2c: mt7621: add Airoha AN7589 support John Crispin
2026-11-12 18:58 ` [PATCH v2 1/3] i2c: mt7621: assert and deassert the reset line John Crispin
2026-11-16 9:58 ` Philipp Zabel [this message]
2026-11-12 18:58 ` [PATCH v2 2/3] dt-bindings: i2c: mt7621: add Airoha AN7589 John Crispin
2026-11-13 17:22 ` Conor Dooley
2026-11-12 18:58 ` [PATCH v2 3/3] i2c: mt7621: add support for " John Crispin
2026-11-13 19:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea675380093047ea19951a31005e3c1e5ca0e04.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Linqi.zhang@airoha.com \
--cc=Rajeev.kumar@airoha.com \
--cc=Weifeng.xu@airoha.com \
--cc=andi.shyti@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=lei.dong@airoha.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sr@denx.de \
--cc=upstream@airoha.com \
--cc=zhengping.zhang@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®