From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH resend] xhci: Do not use GFP_KERNEL in (potentially) atomic context
Date: Wed, 21 Apr 2021 10:46:54 +0300 [thread overview]
Message-ID: <5eb0bea7-46b6-7225-7603-cac3195a92e4@linux.intel.com> (raw)
In-Reply-To: <f30e8c94707b0e3a257f4c628a1b5d7744898109.1618921790.git.christophe.jaillet@wanadoo.fr>
On 20.4.2021 15.32, Christophe JAILLET wrote:
> 'xhci_urb_enqueue()' is passed a 'mem_flags' argument, because "URBs may be
> submitted in interrupt context" (see comment related to 'usb_submit_urb()'
> in 'drivers/usb/core/urb.c')
>
> So this flag should be used in all the calling chain.
> Up to now, 'xhci_check_maxpacket()' which is only called from
> 'xhci_urb_enqueue()', uses GFP_KERNEL.
>
> Be safe and pass the mem_flags to this function as well.
>
> Fixes: ddba5cd0aeff ("xhci: Use command structures when queuing commands on the command ring")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> I'm not 100% sure of the Fixes tag. The commit is the only that introduced
> this GFP_KERNEL, but I've not checked what was the behavior before that.
>
> If the patch is correct, I guess that a cc stable should be welcome.
>
> This patch was proposed on 14/08/20. It has been rebased on latest -next tree.
Added to queue, and added stable tag
Thanks
-Mathias
prev parent reply other threads:[~2021-04-21 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 12:32 Christophe JAILLET
2021-04-21 7:46 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb0bea7-46b6-7225-7603-cac3195a92e4@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®