mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Jean Delvare <jdelvare@suse.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Nirujogi Pratap <pratap.nirujogi@amd.com>,
	Bin Du <bin.du@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Hans Hu <hanshu@zhaoxin.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] i2c: amd-asf-plat: use i2c_adapter_dev()
Date: Tue, 23 Dec 2025 16:51:23 +0530	[thread overview]
Message-ID: <5ec59326-fb63-4236-9c10-3ee37763129b@amd.com> (raw)
In-Reply-To: <20251223-i2c-adapter-dev-wrapper-v1-3-bcf960a48fa9@oss.qualcomm.com>



On 12/23/2025 15:38, Bartosz Golaszewski wrote:
> Use i2c_adapter_dev() where applicable in order to avoid direct
> dereferencing of struct device embedded within struct i2c_adapter.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

Thanks,
Shyam

> ---
>  drivers/i2c/busses/i2c-amd-asf-plat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c
> index ca45f0f233210a3b03a16c4a240012bd524fefb0..271b1b24417d06cc87733268c3191aea16fa1d83 100644
> --- a/drivers/i2c/busses/i2c-amd-asf-plat.c
> +++ b/drivers/i2c/busses/i2c-amd-asf-plat.c
> @@ -209,7 +209,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>  	asf_data[0] = dev_msgs->len;
>  	memcpy(asf_data + 1, dev_msgs[0].buf, dev_msgs->len);
>  
> -	ret = piix4_sb800_region_request(&adap->dev, &dev->mmio_cfg);
> +	ret = piix4_sb800_region_request(i2c_adapter_dev(adap), &dev->mmio_cfg);
>  	if (ret)
>  		return ret;
>  
> @@ -224,7 +224,7 @@ static int amd_asf_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>  	ret = amd_asf_access(adap, msgs->addr, msgs[0].buf[0], asf_data);
>  	piix4_sb800_port_sel(prev_port, &dev->mmio_cfg);
>  	amd_asf_setup_target(dev);
> -	piix4_sb800_region_release(&adap->dev, &dev->mmio_cfg);
> +	piix4_sb800_region_release(i2c_adapter_dev(adap), &dev->mmio_cfg);
>  	return ret;
>  }
>  
> 


  reply	other threads:[~2025-12-23 11:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23 10:08 [PATCH 0/6] i2c: provide and " Bartosz Golaszewski
2025-12-23 10:08 ` [PATCH 1/6] i2c: provide i2c_adapter_dev() Bartosz Golaszewski
2025-12-23 10:08 ` [PATCH 2/6] i2c: piix4: use i2c_adapter_dev() Bartosz Golaszewski
2026-01-12  9:44   ` Jean Delvare
2026-01-13 10:24     ` Wolfram Sang
2025-12-23 10:08 ` [PATCH 3/6] i2c: amd-asf-plat: " Bartosz Golaszewski
2025-12-23 11:21   ` Shyam Sundar S K [this message]
2025-12-23 10:08 ` [PATCH 4/6] i2c: designware-amdisp: " Bartosz Golaszewski
2025-12-27 14:29   ` Andy Shevchenko
2025-12-27 14:30     ` Andy Shevchenko
2026-01-05 19:26   ` Nirujogi, Pratap
2026-01-05 21:42     ` Andy Shevchenko
2025-12-23 10:08 ` [PATCH 5/6] i2c: mv64xxx: " Bartosz Golaszewski
2026-01-05 13:51   ` Gregory CLEMENT
2025-12-23 10:08 ` [PATCH 6/6] i2c: viai2c-zhaoxin: " Bartosz Golaszewski
2025-12-27 14:31   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ec59326-fb63-4236-9c10-3ee37763129b@amd.com \
    --to=shyam-sundar.s-k@amd.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=bin.du@amd.com \
    --cc=brgl@kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=hanshu@zhaoxin.com \
    --cc=jdelvare@suse.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pratap.nirujogi@amd.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®