From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] dt-bindings: clock: ipq5332: drop the few nss clocks definition
Date: Mon, 30 Oct 2023 12:07:56 +0100 [thread overview]
Message-ID: <5ec8490a-1f15-4b98-a3f4-f107f424fd0c@linaro.org> (raw)
In-Reply-To: <20231030-ipq5332-nsscc-v1-2-6162a2c65f0a@quicinc.com>
On 30/10/2023 10:47, Kathiravan Thirumoorthy wrote:
> gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk are
> enabled by default and it's RCG is properly configured by bootloader.
>
> Some of the NSS clocks needs these clocks to be enabled. To avoid
> these clocks being disabled by clock framework, drop these entries.
This is not the way to prevent Linux from disabling the clocks. The way
is to mark them as critical, so I do not think you provided accurate
rationale for bindings change.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-30 11:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 9:47 [PATCH 0/8] Add NSS clock controller support for IPQ5332 Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 1/8] clk: qcom: ipq5332: drop the few nssnoc clocks Kathiravan Thirumoorthy
2023-10-30 18:42 ` Konrad Dybcio
2023-10-30 9:47 ` [PATCH 2/8] dt-bindings: clock: ipq5332: drop the few nss clocks definition Kathiravan Thirumoorthy
2023-10-30 11:07 ` Krzysztof Kozlowski [this message]
2023-10-30 18:56 ` Stephen Boyd
2023-10-31 4:20 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 3/8] dt-bindings: clock: ipq5332: add definition for GPLL0_OUT_AUX clock Kathiravan Thirumoorthy
2023-10-30 11:08 ` Krzysztof Kozlowski
2023-10-30 9:47 ` [PATCH 4/8] clk: qcom: ipq5332: add gpll0_out_aux clock Kathiravan Thirumoorthy
2023-10-30 18:57 ` Stephen Boyd
2023-10-31 4:24 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 5/8] dt-bindings: clock: add IPQ5332 NSSCC clock and reset definitions Kathiravan Thirumoorthy
2023-10-30 11:11 ` Krzysztof Kozlowski
2023-10-31 4:17 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 6/8] clk: qcom: add NSS clock Controller driver for IPQ5332 Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 7/8] arm64: dts: qcom: ipq5332: add support for the NSSCC Kathiravan Thirumoorthy
2023-10-30 11:13 ` Krzysztof Kozlowski
2023-10-31 4:18 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 8/8] arm64: defconfig: build NSS Clock Controller driver for IPQ5332 Kathiravan Thirumoorthy
2023-10-30 10:26 ` Kathiravan Thirumoorthy
2023-10-30 11:08 ` Krzysztof Kozlowski
2023-10-31 4:16 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec8490a-1f15-4b98-a3f4-f107f424fd0c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=quic_kathirav@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®