From: "Kumar, Udit" <u-kumar1@ti.com>
To: Andrew Davis <afd@ti.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j721e: Enable C7x DSP nodes at the board level
Date: Thu, 10 Aug 2023 14:20:37 +0530 [thread overview]
Message-ID: <5ec8b817-e63f-3d76-894d-8af4f4e880db@ti.com> (raw)
In-Reply-To: <20230809180145.53158-1-afd@ti.com>
Thanks Andrew
On 8/9/2023 11:31 PM, Andrew Davis wrote:
> C7x DSP nodes defined in the top-level J721e SoC dtsi files are incomplete
> and will not be functional unless they are extended with both mboxes and
> memory-region information.
>
> As theses only known about at the board integration level, these nodes
> should only be enabled when provided with this information.
>
> Disable the C7x DSP nodes in the dtsi files and only enable the ones that
> are given the required mboxes and memory-region on a given board.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 1 +
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 +
> arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 1 +
> arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index 66aac145e7530..d1235e7c786d6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -1024,6 +1024,7 @@ &c66_1 {
> };
>
> &c71_0 {
> + status = "okay";
> mboxes = <&mailbox0_cluster4>, <&mbox_c71_0>;
> memory-region = <&c71_0_dma_memory_region>,
> <&c71_0_memory_region>;
Series tested on J721E, J784S4 platforms
However I need to apply
https://lore.kernel.org/linux-iommu/0-v2-d2762acaf50a+16d-iommu_group_locking2_jgg@nvidia.com/
patch
Tested-by: Udit Kumar <u-kumar1@ti.com>
https://gist.github.com/uditkumarti/b6320a06fadaaaf174fc0431949f11e1
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 3acd55ffd4ffc..1aeb97b42b34b 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -2134,6 +2134,7 @@ c71_0: dsp@64800000 {
> ti,sci-proc-ids = <0x30 0xff>;
> resets = <&k3_reset 15 1>;
> firmware-name = "j7-c71_0-fw";
> + status = "disabled";
> };
>
> icssg0: icssg@b000000 {
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 0ee4f38ec8f03..377588ba30998 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -1110,6 +1110,7 @@ &c66_1 {
> };
>
> &c71_0 {
> + status = "okay";
> mboxes = <&mailbox0_cluster4>, <&mbox_c71_0>;
> memory-region = <&c71_0_dma_memory_region>,
> <&c71_0_memory_region>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> index e90e43202546e..3c31ab57e959c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> @@ -436,6 +436,7 @@ &c66_1 {
> };
>
> &c71_0 {
> + status = "okay";
> mboxes = <&mailbox0_cluster4>, <&mbox_c71_0>;
> memory-region = <&c71_0_dma_memory_region>,
> <&c71_0_memory_region>;
next prev parent reply other threads:[~2023-08-10 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 18:01 Andrew Davis
2023-08-09 18:01 ` [PATCH 2/3] arm64: dts: ti: k3-j784s4: " Andrew Davis
2023-08-09 18:01 ` [PATCH 3/3] arm64: dts: ti: k3-j721e: Enable C6x " Andrew Davis
2023-08-10 8:50 ` Kumar, Udit [this message]
2023-08-10 22:26 ` [PATCH 1/3] arm64: dts: ti: k3-j721e: Enable C7x " Hari Nagalla
2023-08-10 23:02 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec8b817-e63f-3d76-894d-8af4f4e880db@ti.com \
--to=u-kumar1@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®