From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one
Date: Thu, 11 Mar 2010 09:59:57 +0200 [thread overview]
Message-ID: <5ec8ebd51003102359w277e6aadna483d44ee3ff856f@mail.gmail.com> (raw)
In-Reply-To: <1268292100.11761.1.camel@Joe-Laptop.home>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 638 bytes --]
On Thu, Mar 11, 2010 at 9:21 AM, Joe Perches <joe@perches.com> wrote:>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_hi(ec >> 8);>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_lo(ec >> 8);>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_hi(ec);>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â *op++ = hex_asc_lo(ec);>> Why doesn't this use pack_hex_byte()?> or snprintfsprintf looks like overkill here.
-- With Best Regards,Andy Shevchenkoÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2010-03-11 8:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1268261495-686-1-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-2-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-3-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-4-git-send-email-andy.shevchenko@gmail.com>
[not found] ` <1268261495-686-5-git-send-email-andy.shevchenko@gmail.com>
2010-03-10 23:18 ` OGAWA Hirofumi
2010-03-11 7:14 ` Andy Shevchenko
2010-03-11 9:03 ` OGAWA Hirofumi
2010-03-11 15:00 ` [PATCHv2] fs: fat: use pack_hex_byte() " Andy Shevchenko
2010-03-11 15:12 ` OGAWA Hirofumi
2010-03-11 15:15 ` Andy Shevchenko
[not found] ` <1268468961-17033-1-git-send-email-andy.shevchenko@gmail.com>
2010-03-13 11:09 ` [PATCHv3] " OGAWA Hirofumi
2010-03-11 7:21 ` [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi " Joe Perches
2010-03-11 7:59 ` Andy Shevchenko [this message]
2010-03-11 8:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec8ebd51003102359w277e6aadna483d44ee3ff856f@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®