From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdCNNxP (ORCPT ); Tue, 14 Mar 2017 09:53:15 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42091 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751142AbdCNNv6 (ORCPT ); Tue, 14 Mar 2017 09:51:58 -0400 Subject: Re: [PATCH v1] KVM: s390: use defines for execution controls To: David Hildenbrand , kvm@vger.kernel.org References: <20170313104828.13362-1-david@redhat.com> Cc: Cornelia Huck , linux-kernel@vger.kernel.org From: Christian Borntraeger Date: Tue, 14 Mar 2017 14:51:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170313104828.13362-1-david@redhat.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-TM-AS-GCONF: 00 x-cbid: 17031413-2213-0000-0000-0000015C39AB X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006781; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00833705; UDB=6.00409345; IPR=6.00611363; BA=6.00005209; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014646; XFM=3.00000013; UTC=2017-03-14 13:51:54 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031413-2214-0000-0000-000054A69174 Message-Id: <5ec9b559-40c5-8f64-c2e8-dc8cabd478d4@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-14_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703140110 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2017 11:48 AM, David Hildenbrand wrote: > Let's replace the bitmasks by defines. Reconstructed from code, comments > and commit messages. > > Tried to keep the defines short and map them to feature names. In case > they don't completely map to features, keep them in the stye of ICTL > defines. > > This effectively drops all "U" from the existing numbers. I think this > should be fine (as similarly done for e.g. ICTL defines). The patch does change the binary result and this seems to be related to the U removal. But as far as I can tell this is fine, its just some subtle undefined behaviour change between unsigned/signed which we do not care about. > > I am not 100% sure about the ECA_MVPGI and ECA_PROTEXCI bits as they are > always used in pairs. Just historic baggage, e.g. in 3.10 we set eca to 0xC1002001 and over time we split those out piece by piece. Those two are just the last men standing. I think I am going to apply this with some minor changes (EC* names). Ok when I do the changes?