From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Colin Ian King <colin.i.king@gmail.com>, <ntfs3@lists.linux.dev>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r
Date: Tue, 5 Jul 2022 16:31:57 +0300 [thread overview]
Message-ID: <5ece0504-43ae-84f2-cfcf-ad12520bc195@paragon-software.com> (raw)
In-Reply-To: <20220704185319.592631-1-colin.i.king@gmail.com>
On 7/4/22 21:53, Colin Ian King wrote:
> The assignment to variable r is duplicated, the second assignment
> is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/ntfs3/run.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ntfs3/run.c b/fs/ntfs3/run.c
> index 7609d45a2d72..aba8ab1b9fcb 100644
> --- a/fs/ntfs3/run.c
> +++ b/fs/ntfs3/run.c
> @@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
> e = run->runs + run->count;
> r = run->runs + index;
>
> - r = run->runs + index;
> if (vcn > r->vcn)
> r += 1;
>
Thanks for patch, applied!
prev parent reply other threads:[~2022-07-05 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 18:53 Colin Ian King
2022-07-05 13:31 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ece0504-43ae-84f2-cfcf-ad12520bc195@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®