From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752920AbdASOUc (ORCPT ); Thu, 19 Jan 2017 09:20:32 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:36385 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752669AbdASOUb (ORCPT ); Thu, 19 Jan 2017 09:20:31 -0500 Subject: Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling To: Neil Armstrong , Jose Abreu , , References: <1484656294-6140-1-git-send-email-narmstrong@baylibre.com> <1484656294-6140-3-git-send-email-narmstrong@baylibre.com> <88d1f45a-bfd2-2e6b-6c23-2d0686faa2ce@synopsys.com> <5efc1cc1-05e4-b763-9b1a-db0859988e7b@baylibre.com> CC: , , From: Jose Abreu Message-ID: <5ed16196-4666-d9af-cc5b-51d1a5cebec5@synopsys.com> Date: Thu, 19 Jan 2017 14:20:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5efc1cc1-05e4-b763-9b1a-db0859988e7b@baylibre.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.90] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On 18-01-2017 11:20, Neil Armstrong wrote: > > It's the idea we discussed with Laurent. > Keeping the Synopsys PHY code inside the dw-hdmi driver would be simpler. > > But don't you think adding a proper "ops" structure apart from the plat_data > should be necessary ? > > Neil > An "ops" structure seems fine by me :) We could have one for the generic phy's (the ones that dw-hdmi already supports) and let the developer specify other one if needed. Best regards, Jose Miguel Abreu