mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jagadeesh Kona <quic_jkona@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
	Imran Shaik <quic_imrashai@quicinc.com>,
	Taniya Das <quic_tdas@quicinc.com>,
	"Satya Priya Kakitapalli" <quic_skakitap@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/2] dt-bindings: clock: qcom,sm8450-videocc: Add minItems property
Date: Thu, 19 Jun 2025 15:50:07 +0530	[thread overview]
Message-ID: <5ed72663-da54-46a4-8f44-1ceda4a7d0d9@quicinc.com> (raw)
In-Reply-To: <4657c6d8-8454-478a-aac3-114c6194b72e@linaro.org>



On 6/18/2025 11:56 AM, Krzysztof Kozlowski wrote:
> On 17/06/2025 21:07, Jagadeesh Kona wrote:
>> Add minItems as 1 for power-domains and required-opps properties
>> to allow this binding to be compatible with both single and multiple
>> power domains.
> 
> This is your hardware, so you know how it works thus I expect here
> arguments why this is correct from the hardware point of view. Without
> this, it is impossible to judge whether this is a correct change.
> 
> If I overlook this now, it will be used in discussions by other qcom
> engineers, so unfortunately you see, you need to prepare perfect commits
> now...
>

These clk controllers mainly require MMCX power domain to be enabled to access
the clock registers. But to configure the cam & video PLLs in probe, an additional
MXC power domain also needs to be enabled.

Since the initial DTS changes only added MMCX power domain, this change is required
to be backward compatible with older DTS and avoid ABI breakage as discussed in below
thread.

https://lore.kernel.org/all/cc737a89-77e0-43bc-8766-2c8e9cce1863@quicinc.com/#t

Thanks,
Jagadeesh
 
> Best regards,
> Krzysztof

  reply	other threads:[~2025-06-19 10:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 19:07 [PATCH 0/2] dt-bindings: clock: qcom: Fix SM8450 videocc, camcc power domains support Jagadeesh Kona
2025-06-17 19:07 ` [PATCH 1/2] dt-bindings: clock: qcom,sm8450-videocc: Add minItems property Jagadeesh Kona
2025-06-18  6:26   ` Krzysztof Kozlowski
2025-06-19 10:20     ` Jagadeesh Kona [this message]
2025-06-20  5:56       ` Krzysztof Kozlowski
2025-06-20 17:39         ` Konrad Dybcio
2025-06-20 21:34           ` Dmitry Baryshkov
2025-06-23 17:44             ` Jagadeesh Kona
2025-06-17 19:07 ` [PATCH 2/2] dt-bindings: clock: qcom,sm8450-camcc: " Jagadeesh Kona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ed72663-da54-46a4-8f44-1ceda4a7d0d9@quicinc.com \
    --to=quic_jkona@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_skakitap@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®