From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E88A283CAF for ; Mon, 1 Jun 2026 03:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780285139; cv=none; b=qNh3HjMxwgatDVtY0QB2u3Hh2OlZPoWJe7UfqOVBVS70UIeYbSN0WtRURLYYYxXpg1t6ZWBuDv1+LhDtFhVZeGnycsABEdR0cjxZpgJeUm24CCyFyVEBZSJwRQC1npvIx7vpnePiatzT2WCnM8yRstFPtQlEWfD17Aa7OLRS2Hg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780285139; c=relaxed/simple; bh=O6ttP73ev96TdFerBTl0monlsGmeiqwaQhiYaXkxoCs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=SHQ3Q36h1UxYS6VvvxbR3RrlvQjOh089LFo1zI2l0nlRtkQYlGM918nU9t5SWIQiWFp2frLp65lNxskpzDkji9hzI5xBcdPj9LfH8J9U8EcfhZQ/JUBFVzSZ6pY36X5PSxtaUsObsH/90vwpJbCAvpGWSDMh4ML/KYK2hS1fNjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=abmMi7kD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="abmMi7kD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29E5D1F00893; Mon, 1 Jun 2026 03:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780285137; bh=O6ttP73ev96TdFerBTl0monlsGmeiqwaQhiYaXkxoCs=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=abmMi7kDRBUcPK25SIbXrrcboQhEijQhzClkdz/m1wMDgFUpnvJd/GAj4m0SHsgKS Ye4yk4L4cwCwouAX85hzGIliWsVcNUMOYfX6LczUOF54OL7L7Q3HUgFyb5iOiHZ9Sf i/vLZ73s7DfrGpyBvck3KacB+zX0LE0ZSyGxEAowDzqkc0amaq4pkpuP55fPCM8zN7 R0AovCIeCKZ/KECXEFNNc+AicsDvEJLY68COE/dFn1ZdnLCDUg0VYTYSO0FgPQ07Yu cuuXpWihejYnTTRamokRcgqdWepc/0Sw5lVqc5D/dt8njv0y6G5BucvYR1Ildm7a9B dKPwMmiglR1IQ== Message-ID: <5ed81b4a-1d18-4535-a18c-1bb31969ae78@kernel.org> Date: Mon, 1 Jun 2026 12:38:48 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Harry Yoo Subject: Re: [PATCH v3 1/2] mm/slub: introduce helpers for node partial slab state To: Hao Li , vbabka@kernel.org, akpm@linux-foundation.org Cc: cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260529035120.81304-1-hao.li@linux.dev> <20260529035120.81304-2-hao.li@linux.dev> Content-Language: en-US In-Reply-To: <20260529035120.81304-2-hao.li@linux.dev> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------CNKNMZfV8LoY1cMCfGx7hFIY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------CNKNMZfV8LoY1cMCfGx7hFIY Content-Type: multipart/mixed; boundary="------------DqDzYDgKdkP7Ff00j7RvjNtI"; protected-headers="v1" From: Harry Yoo To: Hao Li , vbabka@kernel.org, akpm@linux-foundation.org Cc: cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-ID: <5ed81b4a-1d18-4535-a18c-1bb31969ae78@kernel.org> Subject: Re: [PATCH v3 1/2] mm/slub: introduce helpers for node partial slab state References: <20260529035120.81304-1-hao.li@linux.dev> <20260529035120.81304-2-hao.li@linux.dev> In-Reply-To: <20260529035120.81304-2-hao.li@linux.dev> --------------DqDzYDgKdkP7Ff00j7RvjNtI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 5/29/26 12:50 PM, Hao Li wrote: > Wrap partial slab count inc/dec and flag set/clear into > helper functions to reduce code duplication. >=20 > Note that __add_partial() is called locklessly in > early_kmem_cache_node_alloc(), but since there is no such use case for > removal, __remove_partial() does not exist. nit: __remove_partial() -> clear_partial_node_state() oh wait, it does exist. Let's drop this paragraph? Otherwise LGTM! Reviewed-by: Harry Yoo (Oracle) > Suggested-by: Harry Yoo > Signed-off-by: Hao Li --=20 Cheers, Harry / Hyeonggon --------------DqDzYDgKdkP7Ff00j7RvjNtI-- --------------CNKNMZfV8LoY1cMCfGx7hFIY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQQ1ub6gR5ogjaKRmOGXBN6rc5S1gUCahz+yAAKCRCGXBN6rc5S 1pjNAP9n82v/7/klMOjhHsDAacPpcFHOqe15jjq50z+NEDhARgEA66WxRiZc9HpP Y00zZLC7w/aGLnZX/qdu9sNShy3XJww= =8rT6 -----END PGP SIGNATURE----- --------------CNKNMZfV8LoY1cMCfGx7hFIY--