From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbcJAEG7 (ORCPT ); Sat, 1 Oct 2016 00:06:59 -0400 Received: from mout.web.de ([212.227.15.4]:54471 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbcJAEGy (ORCPT ); Sat, 1 Oct 2016 00:06:54 -0400 From: SF Markus Elfring Subject: [PATCH] md/dm-stats: Use kmalloc_array() in parse_histogram() To: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Message-ID: <5edaeddf-218f-1a98-d600-84941214db89@users.sourceforge.net> Date: Sat, 1 Oct 2016 06:06:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:PU3qiL8I/IlQk7nfGF9o0NIVclzBo0s48IJGxUGV/CMwX1nTZ8e YJIyMqP6bcrPujSPX3hUVn+Jw9q/fHIsSrEdMkP/vtcr2gmI0FsumqVCn3HuyiuqujDPadY NkqcTC4GT91qrFurdWpaC0uw55W8392lfVlvIRX6f4coAiNPsDn1IM+lLE9mtxVL/1kIW6f 8rcik+Z6M7wJzgVUKximQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:OsXuffWuYIQ=:ZaVFNk+wepSvTbtL7x1Rrm Dqa25GLRZS+e/aKDR/hOMgLmTfqWxj3yBoGDUtJoUg0A5b0SC6M43fJBXesOWmFRuZPCeSlYj 32INBzHOWVK4BU5YHX+JN1aXljOtX+z45bEUM/Rr0HmGsUXrq7/dtos35XlzKNz9s3unc046i AiIRIUMYlZuF58EOvVrInOUpOVyo9Fd7aAg5dPYT1RqRB9gR0WPA7v0LoYM73Hd8hp4Ydoix6 r4V2xspEqAPTkgK6tHFDm5eYy30hwIry4p7vS3vqESnjC3Z/OE0g4PqL1r2R3Sz2R4JohA1bg srO4FrcQfFzpNkOc3sAh6NlfHxOCo1pQ4s1aNm+6GGqd9rzI3cDqUQmMm/n8Cp+VYyotOOY8B yI7b++3/EimxGKSHzQEjOi1FpwVW6YP+F7qkzaBHGLKGON3n7M/aCDJ4DVeHrdKY7AcpVCGh4 kGXc+lI2bQWRazVGIDA6DwSxB0g47LKMqI6DRq0EzzHKX5E+eavCwzr0D4N1nHzt7XjOAVVYw 1ljVzD0GoqasToWiPmdgxyQu+RvPMJqEI4Bbb9lLGtJ+UtP32Mvne6634kBVUwmg417wsN8TM L1t9vRdl/ASVFVtADemhhx3rTD2pqJfoovUAb38EnWoQMwHYrq04/Lrzd2YreOhlK0ON4p48f mZPgsfReUuEfYfdMFagBsKO+8MNMD7qlEj5jOUTDnXuMW81LcjQ7J9B4V+odq2I/I6b7FFPIX TyPRLPmc5p8JRCigj//SVbOmfgiEpXfS1Y/kRH8E8R0SRxwATkiz2Py0u/erODq3VCNEJ/ZHu yCvskTf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 1 Oct 2016 05:55:05 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/md/dm-stats.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-stats.c b/drivers/md/dm-stats.c index 38b05f2..7b79425 100644 --- a/drivers/md/dm-stats.c +++ b/drivers/md/dm-stats.c @@ -917,7 +917,9 @@ static int parse_histogram(const char *h, unsigned *n_histogram_entries, if (*q == ',') (*n_histogram_entries)++; - *histogram_boundaries = kmalloc(*n_histogram_entries * sizeof(unsigned long long), GFP_KERNEL); + *histogram_boundaries = kmalloc_array(*n_histogram_entries, + sizeof(**histogram_boundaries), + GFP_KERNEL); if (!*histogram_boundaries) return -ENOMEM; -- 2.10.0