From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A543D9524 for ; Fri, 3 Jul 2026 10:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783074759; cv=none; b=EdzMgt2EqWf71Bf6CE/J4v4fdCwpEBVfSFeL/qW0RhA1wI6m4XO2u1Nst5XkI1u1fedj7BgT/0FcE9nWK0Yww3mgKDPunzO4uy0Y3ZJKPRKIxpj/jo0ii+Q/YQHaoBpS/iMZ22L4SNzxUnelLk6qYUVlkeLCdd0pEEtbtOw/iXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783074759; c=relaxed/simple; bh=D5ijQV3bUdGx6RAeOYDDyhV2oxFHO7V4Y7ge4JRyKaw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PMFaj3AEgu+c74wdSVfKmtWA71CiV3ZcUlT+heFRUJeGXaBwbWo2FP1fnzyvt8umXTplwl+hO8u1/nhcATw0bWOK+v7bDX2h94yJK0veY8RRME6uO3eWFzD7wt8W2E0ACBwhAg069vP5XBdIETa73KAFaVJGcn8D+74OoPYJY7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oGbcWFTh; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oGbcWFTh" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-474bf35cccdso127252f8f.1 for ; Fri, 03 Jul 2026 03:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783074754; x=1783679554; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=xXqnKE5BVSq5meuyy3aSxrzRU5PavHRibtLm4NqA0hs=; b=oGbcWFTheGuatgzxnFFH6wuCsl5Qb0XbSOH9emVtGr4Wp/p5s+9UGaT95T1+QNp7ON OjOMktfU4yUNmVI4+pIrLqLCBkk0FE6P4Ta8ytqAkknc2s4WZtR6c7+C0imbjlcez0X8 dASoyUvGlF1CG5/vebFc49OJPPn9VTc5aabfhIRDhy/GDoAyyIWjFAI+P5FQzJ9B60nZ cqVW28q5hG/KiFo1ghr7nsW6YugyyvvIqIvRN86V9ioulgmGEL7vt/p/LuKHkfsYfxtB RyvccYfrVkfssvIPiALGePd+e2g2UY8nuXHA9rk48upBsR+KjS3nV6PCFR1ckRIp3CpU +nXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783074754; x=1783679554; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xXqnKE5BVSq5meuyy3aSxrzRU5PavHRibtLm4NqA0hs=; b=bmMNDixFlY/kZgw3pYpMfhhFgLIbsc4tDKvXhzgLezNAPrq+aKzksCzqyO42bSwfY2 FM1mg1xOzPbVd2WwKY8Uf+DZTNmFRrrFbZ9cVaQ4xAwwjDGN/fqFluajDkJaRZ1KcYYu wEWvGR3rUbYKRzDhJ06SBWdfHzOWKNZHI0NAjCGQpjc97kwQalsNTsPcxRf2JfJGVSTR f8giZjuVsbyI3inhtlb0CbNS2jzgTv55vubSG28THHCo2xh/pLBv3l5qaEnMqvj/oba1 zPVw1a2MGmDZWqa6Elec3e6Vr6ov30Xx4rqzBDsGSoDVMERG4GeCQauxJp9onSiCih1R pkSg== X-Forwarded-Encrypted: i=1; AHgh+RqEpULXADCHyOWgzvSUOHwK0SlqHaLSInwThWCHQuXYLz1hgojqx0Csj/nKUVYkotyj+W/fdn5PgOW+2Xg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0YQd7gUG9CbNrd19GgqbSlVGDBq1Iai3SSKXWtuT89YWvYKXE 35SxY2LYGikb1UxSgZPnE3DCnHO2ol1JUsvJWcyGkS4eEROKqpp7+Hj9kDUaElJlXww= X-Gm-Gg: AfdE7ckMYGZrA8NbIjgdygYUXVeF5NiM5RTQPzHLxCCAB77M2FEitglEsr2rEj/36iG OWiWhuA9CTlWNqmWaoym4o49oI8QWOYDMwFxDEx9AU6c/6orCgLJ2f7oT+iD9X5zF+ycrq0TiV8 hiHXUnNfzTa9PzsNZCCmdw1jAH0dh3bXi5RlR6mGIwsDJrgMiMFWVBnHdJVkaooLCTWWs7IOEjz Vkmd/ieTb7m2SRQo8z7JQ3Vi9ZEV/PM3A8IHyQG1tkcJ3xepFkdoJW4OLW0qciO03zX4DzOCMBb 4yWP+GsfCcb6DXv5a3NVa0NQ1ltBjSKoxw437x6wwkiptBv6B/k+l1hw0++wf8qnKx0B+Vjvay/ iAKYJvzxe9pDdtm0VgRcWjNnhXHR1hovKepeYAPnMYJqc3xDsBXlsnT6dIRfZSqZoeoNmJeWc+D ufN+dxwv/AbmW4cEHibriNVreO5MjpkVk5IBM7xzCquzn5gBnDUykmpjZ+G+UylACGqHfRREN94 XFwEQc= X-Received: by 2002:a05:6000:601:b0:476:5eec:309c with SMTP id ffacd0b85a97d-4775a7cb888mr13583163f8f.24.1783074753843; Fri, 03 Jul 2026 03:32:33 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:9b13:921f:4f13:6cbb? ([2a01:e0a:106d:1080:9b13:921f:4f13:6cbb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4ad4sm18103306f8f.11.2026.07.03.03.32.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 03:32:33 -0700 (PDT) Message-ID: <5edfa760-b5b1-4f0e-8a14-2a39d2b99090@linaro.org> Date: Fri, 3 Jul 2026 12:32:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v3 0/2] Lenovo ThinkPad T14s EC thermal monitoring and thermal zone integration To: Daniel Lezcano , sre@kernel.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@roeck-us.net, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: bryan.odonoghue@linaro.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20260701103714.22583-1-daniel.lezcano@oss.qualcomm.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260701103714.22583-1-daniel.lezcano@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/1/26 12:37, Daniel Lezcano wrote: > Hi, > > This series extends the Lenovo ThinkPad T14s embedded controller driver > with environmental monitoring capabilities and integrates the exposed > sensors into the Linux thermal framework. > > The EC provides access to several platform temperature sensors > covering the SoC, keyboard area, bottom cover, charging circuitry, QTM > module and SSD. These sensors are currently used by the firmware for > thermal management but are not exposed to Linux. > > The first patch adds hwmon support for the EC temperature sensors. > > The second patch exposes the EC as a thermal sensor provider in the > device tree and defines thermal zones for the keyboard skin > temperature and the charging circuitry temperature. This allows the > generic thermal framework to react to EC-reported temperatures and > apply standard Linux thermal mitigation policies. > > As the EC protocol is not fully decoded, the passive trip points > get/set actions are missing, so it is not possible to program a > threshold and receive an interrupt when crossed the way up or > down. Consequently, the thermal zone related to the charging circuitry > is polled every two seconds until we can set the trip points in the > EC. > > This series fixes critical thermal issues happening on this platform > where a kernel compilation, or heavy workloads, lead to a system > reboot. > > Tested on a Lenovo ThinkPad T14s Gen 6 (Snapdragon X Elite). > > Thanks, > > Daniel > > --- > Changelog: > v3: > - Removed event based because trip point are not yet well supported > - Added an empty line after variable declaration (Ilpo Järvinen) > - Used MILLIDEGREE_PER_DEGREE from units.h (Ilpo Järvinen) > - Made switch consistent (Ilpo Järvinen) > v2: > - Fixed patch 1 subject prefix > - Removed the fan information part > - Added HWMON_T_ALARM > - Fixed DT change description to reflect what it does really > > Daniel Lezcano (2): > platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for > temperatures > arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin > and charging sensors > > .../qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 68 ++++++++- > drivers/platform/arm64/lenovo-thinkpad-t14s.c | 130 ++++++++++++++++++ > 2 files changed, 197 insertions(+), 1 deletion(-) > Tested-by: Neil Armstrong # on T14s OLED