From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E0DBC4338F for ; Tue, 27 Jul 2021 11:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30E9D61A40 for ; Tue, 27 Jul 2021 11:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236326AbhG0LyX (ORCPT ); Tue, 27 Jul 2021 07:54:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24108 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231856AbhG0LyW (ORCPT ); Tue, 27 Jul 2021 07:54:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627386861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LtEQPY6uW+5xma5Ar89LyNdD4KnBU2eYWcwEqgy6rCw=; b=PaQmkc3CXHMIv89Q8I01ZFEQpfN1UArgYSNs5EzcpVb1SVfOodakntsFiG9wgz4OSjhMGy eHw3+sVJ9rxeRbAgQrNaXegepTtlsEORB/2CdrTYhZ0cQvWL1/pxkvfsDJ8JcNys2yt5wi SXcgEONSvyn7sF1GB65a55VTsiF3M+Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-D05j8AsgPeayyb_UXxtGCw-1; Tue, 27 Jul 2021 07:54:20 -0400 X-MC-Unique: D05j8AsgPeayyb_UXxtGCw-1 Received: by mail-wm1-f70.google.com with SMTP id j11-20020a05600c190bb02902190142995dso588401wmq.4 for ; Tue, 27 Jul 2021 04:54:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LtEQPY6uW+5xma5Ar89LyNdD4KnBU2eYWcwEqgy6rCw=; b=b3DZ9v2+iiTWZ5vMUqrkNWqUUmIHYNqSIQFzcjV7GJCTGrgaBzEniept8Vc+NKfJZU Pyg7JQr4BCvzI59oQjFKCBksHUO9qaHSc23dMVLST2jVaHxAPnlBHaj7PGxjr6UENUoO ixKz6fw66LQ5iP/qq2qr9CsxfZgrnHOiQqHVMgmmUdD3+FMHG8prBdlw3EsPYKCAPSFA c9QoP+UD5Z8Gy8Hs/NtGaQ2evBujke5tniTlYu1Yia8UKCPsMPlnlKIKqT7fDOWLMrBT R6tTcV4wkQySOgymffac34IHVMUrIOu50bctPDmY1oGLydVYJc3TG3NtRI90hRz+79Wo K/Ag== X-Gm-Message-State: AOAM532Ya5CXHlS5MbQOIclFrZiO7waSW9ya7VOBvvoheAGlR+NtBrpv pJGpSt8A71U97C4fydsjt3bvK75hr8IMFyugJdEK6fuTKVqLyIyGQbQf12F61FKbzdRGzy7Gi+N b0SDXYQToFQtDUpHXyo2rabr5 X-Received: by 2002:a7b:c934:: with SMTP id h20mr21724438wml.59.1627386859150; Tue, 27 Jul 2021 04:54:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8hKxMimbBJI2/gsrfN+EOSzugqFuQQA+bNQ9lMvpdcSm+pXDDcJjGJb5sKa3uIjytVPfidw== X-Received: by 2002:a7b:c934:: with SMTP id h20mr21724419wml.59.1627386859005; Tue, 27 Jul 2021 04:54:19 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id d14sm2840806wrs.49.2021.07.27.04.54.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 04:54:18 -0700 (PDT) Subject: Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , Thomas Zimmermann , dri-devel , Peter Robinson , Mark Brown , kernel test robot , Borislav Petkov , Colin Ian King , Daniel Vetter , Dinh Nguyen , Greg Kroah-Hartman , John Stultz , Krzysztof Kozlowski , Linus Walleij , Nicolas Saenz Julienne , Sudeep Holla References: <20210727093015.1225107-1-javierm@redhat.com> From: Javier Martinez Canillas Message-ID: <5ee9e008-a395-56c2-f57f-e3567d6b648b@redhat.com> Date: Tue, 27 Jul 2021 13:54:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Geert, On 7/27/21 1:39 PM, Geert Uytterhoeven wrote: [snip] >>> Perhaps SYSFB should be selected by SYSFB_SIMPLEFB, FB_VESA, >>> and FB_EFI? >> >> It's another option, yes. I just thought that the use of select was not >> encouraged and using depends was less fragile / error prone. > > Select is very useful for config symbols that are invisible to the user (i.e. > cannot be enabled/disabled manually). > Got it. I don't have a strong opinion on this really. In fact, the first version of the patch did use select for the arches but I got as feedback that should use depends instead: https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg351961.html Granted, that was for the arches but you are proposing to do it for the drivers that match against the platform devices registered by sysfb. So it does make more sense to what I did in v1. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat