From: Alex Dewar <alex.dewar90@gmail.com>
To: Bob Copeland <me@bobcopeland.com>,
linux-karma-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: omfs: use kmemdup() rather than kmalloc+memcpy
Date: Wed, 9 Sep 2020 20:04:15 +0100 [thread overview]
Message-ID: <5efaa7be-1890-0169-d133-8dd40b238d6d@gmail.com> (raw)
In-Reply-To: <20200824211755.597245-1-alex.dewar90@gmail.com>
On 24/08/2020 22:17, Alex Dewar wrote:
> Issue identified with Coccinelle.
Gentle ping?
>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
> fs/omfs/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
> index b76ec6b88ded..8867cefa79cf 100644
> --- a/fs/omfs/inode.c
> +++ b/fs/omfs/inode.c
> @@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
> bh = sb_bread(sb, block++);
> if (!bh)
> goto nomem_free;
> - *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
> + *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
> if (!*ptr) {
> brelse(bh);
> goto nomem_free;
> }
> - memcpy(*ptr, bh->b_data, sb->s_blocksize);
> if (count < sb->s_blocksize)
> memset((void *)*ptr + count, 0xff,
> sb->s_blocksize - count);
next prev parent reply other threads:[~2020-09-09 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 21:17 Alex Dewar
2020-09-09 19:04 ` Alex Dewar [this message]
2020-09-14 13:03 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5efaa7be-1890-0169-d133-8dd40b238d6d@gmail.com \
--to=alex.dewar90@gmail.com \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®