From: R Nageswara Sastry <rnsastry@linux.ibm.com>
To: Srish Srinivasan <ssrish@linux.ibm.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu,
James.Bottomley@HansenPartnership.com, jarkko@kernel.org,
zohar@linux.ibm.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, nayna@linux.ibm.com
Subject: Re: [PATCH v2 05/10] pseries/plpks: rename the default wrapping key macro
Date: Fri, 4 Sep 2026 11:43:12 +0530 [thread overview]
Message-ID: <5eff9ad8-a772-429a-b313-b1bf3571206b@linux.ibm.com> (raw)
In-Reply-To: <20260831111738.334857-6-ssrish@linux.ibm.com>
On 31.08.2026 4:47 PM, Srish Srinivasan wrote:
> Rename PLPKS_WRAPKEY_NAME to PLPKS_DEFAULT_WRAPKEY_LABEL to clarify that
> the macro represents the default wrapping key label used by PKWM.
>
> Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
Tested on ppc64le PowerVM LPARs on firmware with wrap/unwrap support,
with and without Secure Boot enabled.
Verified that PKWM initialisation and trusted key seal/unseal continue to
work correctly after the rename.
> ---
> arch/powerpc/platforms/pseries/plpks.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
> index 45278c5a45c1..b553f7b130b6 100644
> --- a/arch/powerpc/platforms/pseries/plpks.c
> +++ b/arch/powerpc/platforms/pseries/plpks.c
> @@ -10,7 +10,7 @@
> #define pr_fmt(fmt) "plpks: " fmt
>
> #define PLPKS_WRAPKEY_COMPONENT "PLPKSWR"
> -#define PLPKS_WRAPKEY_NAME "default-wrapping-key"
> +#define PLPKS_DEFAULT_WRAPKEY_LABEL "default-wrapping-key"
>
> /*
> * To 4K align the {input, output} buffers to the {UN}WRAP H_CALLs
> @@ -938,7 +938,7 @@ int plpks_gen_wrapping_key(void)
> struct label *label;
> int rc = 0, pseries_status = 0;
> struct plpks_var var = {
> - .name = PLPKS_WRAPKEY_NAME,
> + .name = PLPKS_DEFAULT_WRAPKEY_LABEL,
> .namelen = strlen(var.name),
> .policy = PLPKS_WRAPPINGKEY,
> .os = PLPKS_VAR_LINUX,
> @@ -1033,7 +1033,7 @@ int plpks_wrap_object(u8 **input_buf, u64 input_len, u16 wrap_flags,
> bool sb_audit_or_enforce_bit = wrap_flags & BIT(0);
> bool sb_enforce_bit = wrap_flags & BIT(1);
> struct plpks_var var = {
> - .name = PLPKS_WRAPKEY_NAME,
> + .name = PLPKS_DEFAULT_WRAPKEY_LABEL,
> .namelen = strlen(var.name),
> .os = PLPKS_VAR_LINUX,
> .component = PLPKS_WRAPKEY_COMPONENT
--
Thanks and Regards
R.Nageswara Sastry
next prev parent reply other threads:[~2026-09-04 6:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 11:17 [PATCH v2 00/10] Extend PKWM to support user-created wrapping keys Srish Srinivasan
2026-08-31 11:17 ` [PATCH v2 01/10] pseries/plpks: update PKS documentation and maintainer entry Srish Srinivasan
2026-09-04 6:10 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 02/10] pseries/plpks: fix error handling in plpks_read_var() Srish Srinivasan
2026-09-04 6:10 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 03/10] pseries/plpks: improve type consistency and parameter validation Srish Srinivasan
2026-09-04 6:11 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 04/10] keys/trusted_keys: propagate wrapping key generation errors Srish Srinivasan
2026-09-04 6:12 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 05/10] pseries/plpks: rename the default wrapping key macro Srish Srinivasan
2026-09-04 6:13 ` R Nageswara Sastry [this message]
2026-08-31 11:17 ` [PATCH v2 06/10] pseries/plpks: fix self-reference in plpks_var initializer Srish Srinivasan
2026-09-04 6:14 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 07/10] pseries/plpks: hide wrapping_features when unsupported Srish Srinivasan
2026-09-04 6:16 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 08/10] pseries/plpks: add HCALLs for PKWM wrapping key life cycle management Srish Srinivasan
2026-09-04 6:16 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 09/10] keys/trusted_keys: enable PKWM wrapping key selection by label Srish Srinivasan
2026-09-04 6:17 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 10/10] pseries/plpks/wrapkey: expose PKWM wrapping key management to userspace via sysfs Srish Srinivasan
2026-09-04 6:19 ` R Nageswara Sastry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eff9ad8-a772-429a-b313-b1bf3571206b@linux.ibm.com \
--to=rnsastry@linux.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=christophe.leroy@csgroup.eu \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=ssrish@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®