From: Paolo Abeni <pabeni@redhat.com>
To: Thomas Fourier <fourier.thomas@gmail.com>
Cc: stable@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: korina: fix dma_unmap_single() length in korina_rx()
Date: Mon, 19 Oct 2026 15:03:14 +0200 [thread overview]
Message-ID: <5f01c934-990a-4fac-92e7-17d1e4949aec@redhat.com> (raw)
In-Reply-To: <20261013132319.22253-2-fourier.thomas@gmail.com>
On 10/13/26 15:23, Thomas Fourier wrote:
> dma_map_single() is called with size KORINA_RBSIZE and
> dma_unmap_single() is called with size pkt_len which might be smaller.
> Therefore, parts of the buffer may stay mapped after dma_unmap_single()
> is called, which leaks a resource and might leave exposed mapped memory
> that might be eventually freed.
Sashiko noted this is actually a cleanup and not a fix:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261013132319.22253-2-fourier.thomas@gmail.com
and IMHO with very little value.
Dropping this patch.
/P
prev parent reply other threads:[~2026-10-19 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 13:23 Thomas Fourier
2026-10-13 13:40 ` netdev-bot+sinfo
2026-10-14 19:58 ` Daniel Machon
2026-10-19 13:03 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f01c934-990a-4fac-92e7-17d1e4949aec@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fourier.thomas@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®