From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: cwchoi00@gmail.com, kyungmin.park@samsung.com,
myungjoo.ham@samsung.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>, Qiang Yu <yuq825@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Steven Price <steven.price@arm.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
"open list:DRM DRIVERS FOR LIMA"
<dri-devel@lists.freedesktop.org>,
"moderated list:DRM DRIVERS FOR LIMA"
<lima@lists.freedesktop.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH] devfreq: Register devfreq as a cooling device
Date: Thu, 4 Mar 2021 13:47:37 +0000 [thread overview]
Message-ID: <5f06e0c5-b2d9-5e11-01b6-fdd0dac635a7@arm.com> (raw)
In-Reply-To: <20210304125034.28404-1-daniel.lezcano@linaro.org>
Hi Daniel,
On 3/4/21 12:50 PM, Daniel Lezcano wrote:
> Currently the default behavior is to manually having the devfreq
> backend to register themselves as a devfreq cooling device.
>
> There are no so many and actually it makes more sense to register the
> devfreq device when adding it.
>
> Consequently, every devfreq becomes a cooling device like cpufreq is.
>
> Having a devfreq being registered as a cooling device can not mitigate
> a thermal zone if it is not bound to this one. Thus, the current
> configurations are not impacted by this change.
There are also different type of devices, which register into devfreq
framework like NoC buses, UFS/eMMC, jpeg and video accelerators, ISP,
etc.
In some platforms there are plenty of those devices and they all would
occupy memory due to private freq_table in devfreq_cooling, function:
devfreq_cooling_gen_tables().
IIRC in OdroidXU4 there are ~20 devfreq devs for NoC buses.
It's true that they will not affect thermal zones, but unnecessarily,
they all will show up in the /sys/class/thermal/ as
thermal-devfreq-X.
IMO the devfreq shouldn't be tight with devfreq cooling thermal.
CpuFreq is different because it handles only CPUs. Here we have
many different devices.
Regards,
Lukasz
next prev parent reply other threads:[~2021-03-04 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 12:50 Daniel Lezcano
2021-03-04 13:47 ` Lukasz Luba [this message]
2021-03-04 16:53 ` Daniel Lezcano
2021-03-04 17:12 ` Lukasz Luba
2021-03-04 15:06 ` Chanwoo Choi
2021-03-04 16:54 ` Daniel Lezcano
2021-03-05 8:12 ` Steven Price
2021-03-05 9:10 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f06e0c5-b2d9-5e11-01b6-fdd0dac635a7@arm.com \
--to=lukasz.luba@arm.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kyungmin.park@samsung.com \
--cc=lima@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®