From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33F3725742C for ; Wed, 8 Oct 2025 14:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759934900; cv=none; b=ur/gkldlD6Js+g3jb8M0Loi1sz0a6FBSzsh/ppp70dJ3+An2X6UUXvkfs/y49p2OdWEsmx6drDqYIm3o3RdL80Z5ho6Rz5W+1ZztIRyApzWdKE+gNFu+0dnpTMkiN0Z9Rf0lzHAEUolxJlMbsLUtLVVadB4r8J1fjaijO9Kuhv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759934900; c=relaxed/simple; bh=MSLnVgLUNFbIKrWw2FzcH0R8XK0T5k5ELgYs5IakANQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PhoyA9nBNxUpROYfJwsFXJa+zexEK6Iv6Uyoup0taZrWL1nHo3HTf/rYYY5tcwX5A4owVLKTP4pNH1AbPxn8BCrzBGRm3Vnz66Ayh5R5Vxerx+fSN321gFV9NffrRs7RCb75JkMqrIJj189qJbjtDdxWb79jm+vodaHGjwyNPag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EE04122FC; Wed, 8 Oct 2025 07:48:08 -0700 (PDT) Received: from [10.1.28.50] (e122027.cambridge.arm.com [10.1.28.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5F2B3F738; Wed, 8 Oct 2025 07:48:14 -0700 (PDT) Message-ID: <5f095b02-2561-49d7-88a9-0fd82a1c9e00@arm.com> Date: Wed, 8 Oct 2025 15:48:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panfrost: Name scheduler queues after their job slots To: =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Boris Brezillon , kernel@collabora.com, Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter References: <20251002171139.2067139-1-adrian.larumbe@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251002171139.2067139-1-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02/10/2025 18:11, Adrián Larumbe wrote: > Drawing from commit d2624d90a0b7 ("drm/panthor: assign unique names to > queues"), give scheduler queues proper names that reflect the function > of their JM slot, so that this will be shown when gathering DRM > scheduler tracepoints. > > Signed-off-by: Adrián Larumbe Two minor things below, but with those fixed: Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 6 ------ > drivers/gpu/drm/panfrost/panfrost_job.c | 6 +++++- > drivers/gpu/drm/panfrost/panfrost_job.h | 2 ++ > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 22350ce8a08f..d08c87bc63a2 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -668,12 +668,6 @@ static void panfrost_gpu_show_fdinfo(struct panfrost_device *pfdev, > * job spent on the GPU. > */ > > - static const char * const engine_names[] = { > - "fragment", "vertex-tiler", "compute-only" > - }; > - > - BUILD_BUG_ON(ARRAY_SIZE(engine_names) != NUM_JOB_SLOTS); NIT: We could move this to panfrost_job.c and keep the BUILD_BUG_ON. > - > for (i = 0; i < NUM_JOB_SLOTS - 1; i++) { > if (pfdev->profile_mode) { > drm_printf(p, "drm-engine-%s:\t%llu ns\n", > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index c47d14eabbae..0f0340ffee19 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -28,6 +28,10 @@ > #define job_write(dev, reg, data) writel(data, dev->iomem + (reg)) > #define job_read(dev, reg) readl(dev->iomem + (reg)) > > +const char * const engine_names[] = { > + "fragment", "vertex-tiler-compute", "compute-only" > +}; > + > struct panfrost_queue_state { > struct drm_gpu_scheduler sched; > u64 fence_context; > @@ -846,7 +850,6 @@ int panfrost_job_init(struct panfrost_device *pfdev) > .num_rqs = DRM_SCHED_PRIORITY_COUNT, > .credit_limit = 2, > .timeout = msecs_to_jiffies(JOB_TIMEOUT_MS), > - .name = "pan_js", > .dev = pfdev->dev, > }; > struct panfrost_job_slot *js; > @@ -887,6 +890,7 @@ int panfrost_job_init(struct panfrost_device *pfdev) > > for (j = 0; j < NUM_JOB_SLOTS; j++) { > js->queue[j].fence_context = dma_fence_context_alloc(1); > + args.name = engine_names[j]; > > ret = drm_sched_init(&js->queue[j].sched, &args); > if (ret) { > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.h b/drivers/gpu/drm/panfrost/panfrost_job.h > index 5a30ff1503c6..52ff10b8d3d0 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.h > +++ b/drivers/gpu/drm/panfrost/panfrost_job.h > @@ -53,6 +53,8 @@ struct panfrost_jm_ctx { > struct drm_sched_entity slot_entity[NUM_JOB_SLOTS]; > }; > > +extern const char * const engine_names[]; NIT: Now this is no longer a local variable I think we should prefix it, e.g. panfrost_engine_names. > + > int panfrost_jm_ctx_create(struct drm_file *file, > struct drm_panfrost_jm_ctx_create *args); > int panfrost_jm_ctx_destroy(struct drm_file *file, u32 handle); > > base-commit: 30531e9ca7cd4f8c5740babd35cdb465edf73a2d