From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78A2C31E51 for ; Tue, 18 Jun 2019 06:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 869152064B for ; Tue, 18 Jun 2019 06:42:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=neuling.org header.i=@neuling.org header.b="jN8u+t5m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728660AbfFRGmt (ORCPT ); Tue, 18 Jun 2019 02:42:49 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:47147 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfFRGmY (ORCPT ); Tue, 18 Jun 2019 02:42:24 -0400 Received: from neuling.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 45Scty2wxwz9sBr; Tue, 18 Jun 2019 16:02:50 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=neuling.org; s=201811; t=1560837770; bh=1ua8AxnSFGbmeRZ2O1z1wWr64nG/aauwxkcL742kDIY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=jN8u+t5m4SKIu2gD0YZGvesqfBmLrEZzWGyMHgUn2HXPgyoyjyQyCTgUDa2QJ/g7n 3o6Q7T4cUpV2BgJVRv+Fq/kp9exSjfiWlatMa4hae0heekBMiwD7g8wQe9tkbS7dFz 6/Yxq30lUp0zrfiUkj00QG3ZMa/Ek6H33lBj17BpHd6idGBdlPoHMTMOdmQliUDLZK 9KN/XbfAcqEgYImEkOJwJoOb23iqasQXg56ZK5Rn0x29GphCm36D7sGXERRriKWGvy LvtMhq43jkoDakvs/uilAdeGSpAa5C4xiY/B4aI5jqf63t812J8VQi9T6tHdahKEbA OuOrRMtqvfkTQ== Received: by neuling.org (Postfix, from userid 1000) id 4D0E92A2538; Tue, 18 Jun 2019 16:02:50 +1000 (AEST) Message-ID: <5f09710b3df41a873d05389fab31e9b716211d3c.camel@neuling.org> Subject: Re: [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() From: Michael Neuling To: Ravi Bangoria , mpe@ellerman.id.au Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, christophe.leroy@c-s.fr, naveen.n.rao@linux.vnet.ibm.com Date: Tue, 18 Jun 2019 16:02:50 +1000 In-Reply-To: <20190618042732.5582-2-ravi.bangoria@linux.ibm.com> References: <20190618042732.5582-1-ravi.bangoria@linux.ibm.com> <20190618042732.5582-2-ravi.bangoria@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.32.2 (3.32.2-1.fc30) MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Can you add the word "comment" to this subject. Currently it implies there = are code changes here. Mikey On Tue, 2019-06-18 at 09:57 +0530, Ravi Bangoria wrote: > do_dabr() was renamed with do_break() long ago. But I still see > some comments mentioning do_dabr(). Replace it. >=20 > Signed-off-by: Ravi Bangoria > --- > arch/powerpc/kernel/hw_breakpoint.c | 2 +- > arch/powerpc/kernel/ptrace.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/powerpc/kernel/hw_breakpoint.c > b/arch/powerpc/kernel/hw_breakpoint.c > index a293a53b4365..1908e4fcc132 100644 > --- a/arch/powerpc/kernel/hw_breakpoint.c > +++ b/arch/powerpc/kernel/hw_breakpoint.c > @@ -232,7 +232,7 @@ int hw_breakpoint_handler(struct die_args *args) > * Return early after invoking user-callback function without restoring > * DABR if the breakpoint is from ptrace which always operates in > * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal > - * generated in do_dabr(). > + * generated in do_break(). > */ > if (bp->overflow_handler =3D=3D ptrace_triggered) { > perf_bp_event(bp, regs); > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c > index 684b0b315c32..44b823e5e8c8 100644 > --- a/arch/powerpc/kernel/ptrace.c > +++ b/arch/powerpc/kernel/ptrace.c > @@ -2373,7 +2373,7 @@ void ptrace_triggered(struct perf_event *bp, > /* > * Disable the breakpoint request here since ptrace has defined a > * one-shot behaviour for breakpoint exceptions in PPC64. > - * The SIGTRAP signal is generated automatically for us in do_dabr(). > + * The SIGTRAP signal is generated automatically for us in do_break(). > * We don't have to do anything about that here > */ > attr =3D bp->attr;