From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Schspa Shi <schspa@gmail.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com
Cc: linux-kernel@vger.kernel.org, zhaohui.shi@horizon.ai
Subject: Re: [PATCH v6 2/2] sched/rt: Trying to push current task when target disable migrating
Date: Wed, 13 Jul 2022 12:02:42 +0200 [thread overview]
Message-ID: <5f0d6bef-9e9e-7083-9657-ae5e6dd10d2a@arm.com> (raw)
In-Reply-To: <20220712150506.632304-2-schspa@gmail.com>
On 12/07/2022 17:05, Schspa Shi wrote:
[...]
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 7bd3e6ecbe45e..e2d7b085a93d9 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2136,6 +2136,12 @@ static int push_rt_task(struct rq *rq, bool pull)
> */
> task = pick_next_pushable_task(rq);
> if (task == next_task) {
> + /*
> + * If next task has now disabled migrating, see if we
> + * can push the current task.
> + */
> + if (unlikely(is_migration_disabled(task)))
Doesn't this need a `put_task_struct(next_task)`?
> + goto retry;
> /*
> * The task hasn't migrated, and is still the next
> * eligible task, but we failed to find a run-queue
Why not introduce in push_dl_task() as well?
next prev parent reply other threads:[~2022-07-13 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 15:05 [PATCH v6 1/2] sched/rt: fix bad task migration for rt tasks Schspa Shi
2022-07-12 15:05 ` [PATCH v6 2/2] sched/rt: Trying to push current task when target disable migrating Schspa Shi
2022-07-12 15:17 ` Steven Rostedt
2022-07-13 10:02 ` Dietmar Eggemann [this message]
2022-07-13 12:24 ` Schspa Shi
2022-07-12 15:16 ` [PATCH v6 1/2] sched/rt: fix bad task migration for rt tasks Steven Rostedt
2022-07-12 15:26 ` Dietmar Eggemann
2022-07-12 15:35 ` Schspa Shi
2022-07-13 9:43 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f0d6bef-9e9e-7083-9657-ae5e6dd10d2a@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=schspa@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhaohui.shi@horizon.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®