From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B24D036403F for ; Wed, 17 Dec 2025 15:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765985291; cv=none; b=dH1qxm76KwsDV2YG4/pzUZ4/dCRzlNUNy9ZvPSX/mV0aStoJ70YNcfpvcGglaJK/Qu6kuWDaR9uyY8O5krZjoar0tsSW9RH79Qx/j1wZNe81E24WFJf7Lj1oTVmJ9t82b1nWP2tGkRw6l4Ad1k3fS38WCiAV/SQ650vHaUt9ZbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765985291; c=relaxed/simple; bh=vS5+QGMhJqTRxwmGixf3B1LtkbQB7ZugwrDt7jvSwIE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HVINnbXtUGSmCj/4L43nVG8Y3hmEwTBcf6KzE2NlQs1Ylyl5kGIpnHMg6M7am/wBKez8pAV6jbR6BrUpm0ycwqaOr7aGNuCH+KTIzRcpSankncbl89a7PHoig9F5WjcmYtZ/5B3qcMhtFXHlvg1Nw4leXa7r7RVT7Fw/R8CgtQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lh3QtnEj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZdaZT/SV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lh3QtnEj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZdaZT/SV" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHCLXX82503889 for ; Wed, 17 Dec 2025 15:28:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NpvxrAGKgOQQiuwNm3XoE1ZgU+P+KY6K4nV1l37VaBo=; b=lh3QtnEjO5uRQCtF uFnxIsyXTPhpuU+pkhgQw1Pnsc9ys/7hLvjsdAr2cJx02hsZ4saAqR2JV01Gpw7t RaoW5Fid69HAJqmOWUn4eTFpHM71BruTdebKDlrEwp4tDlhmuYtdmnxN1JmAVRTN 1lM/s9zWQdAy0fcOO/q6p2LrIXeDtExAHweYhXHhZkjAKxyneh66RoV6kSHpf+v5 AvDGog8+UTNJwk7TKbdwf1lHuHoN0jwRRksXJMxA8Iyg8LvEUSiAP2tbx0ICxuad 1Y/GUWKmk5Wi2x8xExrCs2aS251WZgjRniYf2YQAPw9CgWqVH/h2F0XKUT/w6bEK YX5wEA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3rqa9d95-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 15:28:08 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8adc67e5340so72621785a.2 for ; Wed, 17 Dec 2025 07:28:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765985288; x=1766590088; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NpvxrAGKgOQQiuwNm3XoE1ZgU+P+KY6K4nV1l37VaBo=; b=ZdaZT/SV64uzOUBsdULUozLOk4m/0oqe4XR6mmKNbjh+wGB/G3nvKcBGHsywCyNZC3 6wnZcMd4LkqD6ADnohQqPxY9q+m9OZ/UzUUATcQZ6R+f4X5BoM5Ub+Ln97C2vei4WcYz DzjFgFRQVp64d8oFRncDXhBvQBjrj6uAz9lFEqwD9j/WkCeID1mMpuwn0odo9vhC0Ufb zbB7B7ca/1m5k6KSiAhBSG35KTvTFAlO8wTsbTo6Q20FXT+zpqsJimRZodsBmJgYBEW8 ZxZH20IbRz4bUsO+Xc8TnrYrwEJI45ag8nljEvZcVItUcC4fJrahUOZlFK8kwF20ZxUn 4TeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765985288; x=1766590088; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NpvxrAGKgOQQiuwNm3XoE1ZgU+P+KY6K4nV1l37VaBo=; b=tR4RB1kg4SfC5pvrzKhdYc7qfpDiFJWX42lyllmBIMVsNWRTp/TEPezP9FpmI21KKq 1BK5eXgcbyB0Ei33ZAhC+R5rj04eJ+wgMPNAQvvH+bxtzp2BzlGhZ6TgHN9Wg7hoMoFc M6BHNbmlELmqrk2jamKYNlDlV+1/u9bovvo5I5WyEc0bVaKf2eb+yspf2bw6ri1zN5XX 81Xa2AwSdu2xRCEoicjk4jKoaIXWMr0II+Rp/CHboEcokkeGqVmQ5xD5+ntw6DkDTuki Bct4u3LwFyPgNwLaVTmskPjV75VmzkaKDt5TZnUT2Is1zMTm3SXC26fdh/jmptazoCrS fyCw== X-Forwarded-Encrypted: i=1; AJvYcCUCkWhsSmkUJ5bH0MT8sKAcSPpeSNvD1i20e03Ff/cNf74BAsEx0bl1hIRzEh/HiYY08rGznng1+cM/fA8=@vger.kernel.org X-Gm-Message-State: AOJu0YwnDYwOHEtJM4wrU/POckYz2p6y9e04cumqBQRvzOILcEjcNHmx A7Ws8C/5WCjGDdci4ADnfilPZFpPkb5H11AdF08IOdPa6uxmgmW1gp9WIqCagAkbkoJmKFLcBG3 55NtOS2CT5PxuuVZdZ7oRqlC97f6iF2ACci4wbdRVd2KxisWm/qApNOnciVFvoW9CHv0= X-Gm-Gg: AY/fxX6IpW3LJauIPQ3jXsgnpS3U5ID+O/jmN+gvdthszwDuBOW9dj6fwCTUQ5JXNV2 IBzOAG/4V1vHJUhVAhjkbUxL5GFa94go3mMw5SeNAApe10dRcbjrZ4S+6tt+BOrRoirLtg18RE+ S4iF3t7kCntHpDu1wVGU+jCUJpqGoUX/aU8FZV+DmO3YkK/L1BWS6DVxSwSV0W84CO1kq6F281T Ml+bvOvSpnnzd7ndt5gZWd4B8kIJJEyDVsXToecOlpSgmvYNTOnukpEN0JO2Bdrdz9qIVtYxGEN 0hRTEv8oKU6ObyJHhxRzshmnlQJ32agZIrrpVb8FlfCnnpwykVZty4ZboohABfsGXXe3Yp9XBrX MqZPgMXA/NPkXww/00P9c9uuisZe8iaPjJcgGHuqxwk6PObUn/EMlEwDNtOXLif5cOA== X-Received: by 2002:a05:622a:15ca:b0:4ee:87e:dedf with SMTP id d75a77b69052e-4f1d06108d3mr186906801cf.8.1765985287961; Wed, 17 Dec 2025 07:28:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQYxBozUDpQ8zpkUoU2aSZ8eRnOyZoPy/cVs78PuFM8EGLqXffXzVf5Xsu375vNciuAlo7fg== X-Received: by 2002:a05:622a:15ca:b0:4ee:87e:dedf with SMTP id d75a77b69052e-4f1d06108d3mr186906391cf.8.1765985287417; Wed, 17 Dec 2025 07:28:07 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f584800sm2692758a12.30.2025.12.17.07.28.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 07:28:06 -0800 (PST) Message-ID: <5f1282b2-2447-4ce8-a943-90c88e7f5835@oss.qualcomm.com> Date: Wed, 17 Dec 2025 16:28:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: Enable known blocks and add placeholders To: David Heidelberg , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251216-placeholders-v1-1-d7d544200e7c@ixit.cz> <5199fe6a-550a-4366-bee2-d4ab08ed248b@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5199fe6a-550a-4366-bee2-d4ab08ed248b@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: bhq16UkRxNH9tC9DptiaauPtu-13JNLS X-Authority-Analysis: v=2.4 cv=ALq93nRn c=1 sm=1 tr=0 ts=6942cc09 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=p0WdMEafAAAA:8 a=6oNqwxbLjnVaV5MYmCcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDEyMSBTYWx0ZWRfXzu70BHtCsG2V osZdDAtQt4YrsXS9gmO8gAj2r1AlET5YHM93TMT3bmUCVzpBL3PlhI3MENErZm20d9tJOyt3D7H rPpZjRT8uYJIPl97cDJ1tEJuaQQ0LC7Pf4Y+aZp8mhHa09tyaw3LnqN4mp/BJAxaQn6KiEBw7Lq NLB4w8cvOrsqpneDl5iM90ORzAhiN3XO+dZGj8ElhLB+HbN2E7iYnoyfnVtzECGLawOyMJKpM6p j9ssJNqQ4Rf+rrK0WLFyPNfjjDOg3+3w6Xb1CVI7c8gho0XLg4eJ0wr/EBxrRZvhxYm8htQ+1xh Hn+LFiyY1SWoGWBrf2Gr/6Z2HB2xYQZg3IoHl+q5v3w0OlXsK187I+k3ZCxspSm4WlvjXhT9jOA FbCqkj24V8jj1HNWXqLBX5vdHQ7Zlg== X-Proofpoint-GUID: bhq16UkRxNH9tC9DptiaauPtu-13JNLS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_03,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170121 On 12/17/25 4:00 PM, David Heidelberg wrote: > On 17/12/2025 13:04, Konrad Dybcio wrote: >> On 12/16/25 9:34 PM, David Heidelberg via B4 Relay wrote: >>> From: David Heidelberg >>> >>> We know these devices are present; most of them are supported by >>> downstream and are close to the mainline kernels. >>> >>> This adds placeholders for: >>>   - front camera (imx371) >>>   - rear cameras (imx519, imx376k) >>>   - actuators >>>   - NFC node on i2c3 >>> >>> This is very handy when rebasing the integration tree with >>> support for multiple different blocks at the same time. >>> >>> Signed-off-by: David Heidelberg >>> --- >> >> [...] >> >>> +&i2c3 { >>> +    clock-frequency = <400000>; >>> + >>> +    status = "okay"; >>> + >>> +    /* nxp,nxp-nci-i2c @28 */ >> >> This seems fairly straightforward to enable - could you just >> do that instead? > > I have patch for it in-tree, but most likely not correct. See notes in: > > https://gitlab.com/sdm845/sdm845-next/-/commit/eeb765bb1166e020a771ed712fec76b56da229ee > > For now, I can only confirm the device is on the i2c address. Taking a look at just the names of the sdm845-qrd.dtsi/sony modifications for their sdm845 phones in downstream which I presume have the exact same chip anyway: notes based on observation and driver (drivers/nfc/nq-nci.c) nq@28 { compatible = "qcom,nq-nci"; reg = <0x28>; qcom,nq-irq = <&tlmm 63 0x00>; // interrupt, duplicated below qcom,nq-ven = <&tlmm 12 0x00>; // voltage enable, ACTIVE_HIGH qcom,nq-firm = <&tlmm 62 0x00>; // firmware download, ACTIVE_HIGH qcom,nq-clkreq = <&pm8998_gpios 21 0x00>; // clock enable, INPUT qcom,nq-esepwr = <&tlmm 116 0x00>; // eSE power enable, ACTIVE_HIGH interrupt-parent = <&tlmm>; interrupts = <63 0>; [... blurb ...] }; pm8998_gpio_21: pm8998_gpio_21 { pins = "gpio21"; function = "normal"; input-enable; bias-pull-down; power-source = <1>; }; /* GPIO_62: NFC_DWLD_EN */ sdm_gpio_62: sdm_gpio_62 { mux { pins = "gpio62"; function = "gpio"; }; config { pins = "gpio62"; drive-strength = <2>; bias-disable; output-low; }; }; /* GPIO_63: NFC_IRQ */ sdm_gpio_63: sdm_gpio_63 { mux { pins = "gpio63"; function = "gpio"; }; config { pins = "gpio63"; drive-strength = <2>; bias-pull-down; input-enable; }; }; /* GPIO_12 : NFC_VEN */ sdm_gpio_12: sdm_gpio_12 { mux { pins = "gpio12"; function = "gpio"; }; config { pins = "gpio12"; drive-strength = <2>; bias-disable; output-low; }; }; Konrad