mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"magnus.damm" <magnus.damm@gmail.com>,
	Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
Date: Mon, 8 Jun 2026 14:23:18 +0200	[thread overview]
Message-ID: <5f1b0d7d-3105-4371-a603-7e7bacd5f112@kernel.org> (raw)
In-Reply-To: <TY3PR01MB113461D43EFBA56BAE7C8F403861C2@TY3PR01MB11346.jpnprd01.prod.outlook.com>

On 08/06/2026 14:15, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 08 June 2026 13:12
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 13:59, Biju Das wrote:
>>> Hi Krzysztof Kozlowski,
>>>
>>>> -----Original Message-----
>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>>> Sent: 08 June 2026 12:55
>>>> Subject: [PATCH] dt-bindings: mfd: syscon: Revert
>>>> renesas,r9a08g046-lvds-cmn
>>>>
>>>> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
>>>> LVDS_CMN syscon for the RZ/G3L") because it is completely not
>>>> matching reality and clearly incorrect in respect of renesas,r9a08g046- lvds-cmn.
>>>>
>>>> It wasn't ever build-tested by author on their DTS, either.
>>>
>>> You are wrong here.
>>>
>>> It is tested with below DTS,
>>
>> Sure, I believe you. Binding is still obviously wrong and does not match the DTS at all.
> 
> You are not actually pointing to the mistake in the bindings. It is reviewed by Conor.

I described it very clear in the part of the msg YOU REMOVED.

Does not matter if it was reviewed by Conor. The patch looked correct
for our eyes when looking ALONE at this patch, I also would not spot the
issue. You as the author have the complete picture and you should see
that it is completely bogus combination of compatibles.

Best regards,
Krzysztof

  reply	other threads:[~2026-06-08 12:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 11:55 Krzysztof Kozlowski
2026-06-08 11:59 ` Biju Das
2026-06-08 12:12   ` Krzysztof Kozlowski
2026-06-08 12:15     ` Biju Das
2026-06-08 12:23       ` Krzysztof Kozlowski [this message]
2026-06-08 13:53         ` Biju Das
2026-06-08 13:57           ` Krzysztof Kozlowski
2026-06-08 14:04             ` Biju Das
2026-06-08 14:05               ` Krzysztof Kozlowski
2026-06-08 14:45                 ` Biju Das
2026-06-15  6:10 ` Krzysztof Kozlowski
2026-06-15  6:27   ` Biju Das
2026-06-15 10:21 ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f1b0d7d-3105-4371-a603-7e7bacd5f112@kernel.org \
    --to=krzk@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=tommaso.merciai.xr@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®