From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD71EB64DA for ; Mon, 19 Jun 2023 07:43:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbjFSHnD (ORCPT ); Mon, 19 Jun 2023 03:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbjFSHmp (ORCPT ); Mon, 19 Jun 2023 03:42:45 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C21B410CA; Mon, 19 Jun 2023 00:42:35 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Ql1rG1c22ztQYY; Mon, 19 Jun 2023 15:39:58 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 19 Jun 2023 15:42:32 +0800 Subject: Re: [PATCH] memcg: remove unneeded header files To: Michal Hocko CC: , , , , , , , References: <20230617072658.1826560-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <5f1d08ea-72af-f287-9ec5-3c485c1e4f0c@huawei.com> Date: Mon, 19 Jun 2023 15:42:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/19 15:19, Michal Hocko wrote: > On Sat 17-06-23 15:26:58, Miaohe Lin wrote: >> Remove some unneeded header files. No functional change intended. > > Header inclusion cleanups are certainly welcome but it would be much > more preferred to explain why those are not needed. As build test follow > ups show this is much more subtle than it seems. Will make it clear in v2. Thanks for comment.