From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF256C433E0 for ; Mon, 18 Jan 2021 08:08:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79CC52245C for ; Mon, 18 Jan 2021 08:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387492AbhARIID (ORCPT ); Mon, 18 Jan 2021 03:08:03 -0500 Received: from smtprelay0047.hostedemail.com ([216.40.44.47]:56604 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733285AbhARIHy (ORCPT ); Mon, 18 Jan 2021 03:07:54 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 93B0D1800BC3D; Mon, 18 Jan 2021 08:07:09 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: twig35_0f0e18727547 X-Filterd-Recvd-Size: 3611 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Mon, 18 Jan 2021 08:07:08 +0000 (UTC) Message-ID: <5f204c6bde4324cd73ab9b6f6b5bf9d436e30abe.camel@perches.com> Subject: Re: [PATCH] mm/memcontrol: Remove unneeded semicolons From: Joe Perches To: Chengyang Fan , akpm@linux-foundation.org Cc: richard.weiyang@gmail.com, linux-kernel@vger.kernel.org In-Reply-To: <0e528801-78ed-e71c-1237-648a86f0791c@huawei.com> References: <20210118015229.2599778-1-cy.fan@huawei.com> <0037bf34a326f44585c634d346c8134cf9efc062.camel@perches.com> <0e528801-78ed-e71c-1237-648a86f0791c@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" MIME-Version: 1.0 Date: Sun, 17 Jan 2021 23:03:29 -0800 User-Agent: Evolution 3.38.1-1 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-01-18 at 11:18 +0800, Chengyang Fan wrote: > I'm doing the work. Good, thank you. > Should I submit patches individually or together? I believe you should submit multiple patches, one for each subsystem. For instance, a single patch should change all of: > arch/powerpc/include/asm/book3s/32/mmu-hash.h:static inline void cleanup_cpu_mmu_context(void) { }; > arch/powerpc/include/asm/book3s/64/mmu.h:static inline void radix_init_pseries(void) { }; > arch/powerpc/include/asm/firmware.h:static inline void pseries_probe_fw_features(void) { }; > arch/powerpc/include/asm/kvm_ppc.h:static inline void kvmppc_alloc_host_rm_ops(void) {}; > arch/powerpc/include/asm/kvm_ppc.h:static inline void kvmppc_free_host_rm_ops(void) {}; > arch/powerpc/include/asm/kvm_ppc.h:static inline void kvmppc_free_pimap(struct kvm *kvm) {}; > arch/powerpc/include/asm/paca.h:static inline void allocate_paca_ptrs(void) { }; > arch/powerpc/include/asm/paca.h:static inline void allocate_paca(int cpu) { }; > arch/powerpc/include/asm/paca.h:static inline void free_unused_pacas(void) { }; > arch/powerpc/include/asm/rtas.h:static inline void rtas_initialize(void) { }; > arch/powerpc/include/asm/setup.h:static inline void setup_barrier_nospec(void) { }; > arch/powerpc/include/asm/setup.h:static inline void do_barrier_nospec_fixups_range(bool enable, void *start, void *end) { }; > arch/powerpc/include/asm/setup.h:static inline void setup_spectre_v2(void) {}; > arch/powerpc/include/asm/simple_spinlock.h:static inline void splpar_spin_yield(arch_spinlock_t *lock) {}; > arch/powerpc/include/asm/simple_spinlock.h:static inline void splpar_rw_yield(arch_rwlock_t *lock) {}; > arch/powerpc/include/asm/smp.h:static inline void smp_release_cpus(void) { }; > arch/powerpc/include/asm/xmon.h:static inline void xmon_setup(void) { }; > arch/powerpc/include/asm/xmon.h:static inline void xmon_register_spus(struct list_head *list) { }; > arch/powerpc/kernel/prom.c:static inline void save_fscr_to_task(void) {}; > arch/powerpc/kernel/setup.h:static inline void setup_power_save(void) { }; > arch/powerpc/kernel/setup.h:static inline void check_smt_enabled(void) { }; > arch/powerpc/kernel/setup.h:static inline void setup_tlb_core_data(void) { }; > arch/powerpc/kernel/setup.h:static inline void exc_lvl_early_init(void) { }; > arch/powerpc/kernel/setup.h:static inline void emergency_stack_init(void) { }; > arch/powerpc/kernel/setup.h:static inline void kvm_cma_reserve(void) { }; > arch/powerpc/platforms/powernv/subcore.h:static inline void update_subcore_sibling_mask(void) { }; > arch/powerpc/platforms/pseries/pseries.h:static inline void smp_init_pseries(void) { };