From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F40C7618A for ; Tue, 14 Mar 2023 09:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbjCNJ1E (ORCPT ); Tue, 14 Mar 2023 05:27:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjCNJ1C (ORCPT ); Tue, 14 Mar 2023 05:27:02 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4816889F15; Tue, 14 Mar 2023 02:27:01 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 817816603009; Tue, 14 Mar 2023 09:26:59 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678786020; bh=OeV9dWUuKMcE+RWaT+yQ3SgSvJdeE8qh9/3murEwb7w=; h=Date:Subject:To:References:From:In-Reply-To:From; b=TbMncgSImrKuZFx64fmPEjtJvdMamA4BmxUVGsH9Z/qU6orcBGPcR+NfLjkVbSjX/ suGRXGeMZDCiP7O/j1aDPfhbCbI1tAYoZtl7w7ZiSJ9/975CL1WMdvUSBSuxg1KN92 y+Q5Ui4Umg6d1o4jo2O5OeDYz9JUVuZFesDBsAgVi56aihLi9J2XcAV/HjASbmrn8F ISm5c0YUBq9jysXFNPOmJzFZlo2rmwVAaNYHxQMb6Krqp18DlMYsehcUtxSMfnxmzD SYLjnwrXEVYif53YgaNrGUA2MjGbhsP0DViFgH0DA9Bno5P2KzIXpHFX30/VSZL2JB IUomVV8ADZvVg== Message-ID: <5f219379-cccb-d8ca-ed23-4106ca3ecf3a@collabora.com> Date: Tue, 14 Mar 2023 10:26:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] i2c: mediatek: add support for MT7981 SoC Content-Language: en-US To: Daniel Golle , linux-i2c@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Qii Wang , Rob Herring , Krzysztof Kozlowski , Matthias Brugger References: From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 14/03/23 02:18, Daniel Golle ha scritto: > Signed-off-by: Daniel Golle > --- > drivers/i2c/busses/i2c-mt65xx.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > index 43dd966d5ef5..54cabd366403 100644 > --- a/drivers/i2c/busses/i2c-mt65xx.c > +++ b/drivers/i2c/busses/i2c-mt65xx.c > @@ -431,6 +431,18 @@ static const struct mtk_i2c_compatible mt8168_compat = { > .max_dma_support = 33, > }; > > +static const struct mtk_i2c_compatible mt7981_compat = { > + .regs = mt_i2c_regs_v3, I've found a downstream kernel saying that MT7981 uses `mt_i2c_regs_v2`, hence the question: Are you sure that this is supposed to be v3? Regards, Angelo > + .pmic_i2c = 0, > + .dcm = 0, > + .auto_restart = 1, > + .aux_len_reg = 1, > + .timing_adjust = 1, > + .dma_sync = 1, > + .ltiming_adjust = 1, > + .max_dma_support = 33 > +}; > + > static const struct mtk_i2c_compatible mt7986_compat = { > .quirks = &mt7622_i2c_quirks, > .regs = mt_i2c_regs_v1, > @@ -516,6 +528,7 @@ static const struct of_device_id mtk_i2c_of_match[] = { > { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat }, > { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat }, > { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat }, > + { .compatible = "mediatek,mt7981-i2c", .data = &mt7981_compat }, > { .compatible = "mediatek,mt7986-i2c", .data = &mt7986_compat }, > { .compatible = "mediatek,mt8168-i2c", .data = &mt8168_compat }, > { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },