From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424AbeCPQUV (ORCPT ); Fri, 16 Mar 2018 12:20:21 -0400 Received: from foss.arm.com ([217.140.101.70]:59684 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999AbeCPQTr (ORCPT ); Fri, 16 Mar 2018 12:19:47 -0400 Subject: Re: [PATCH 0/2] irqchip/gic*: Complain about the use of IRQ_TYPE_NONE To: Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Thomas Gleixner , Jason Cooper References: <20180316145511.28362-1-marc.zyngier@arm.com> From: Robin Murphy Message-ID: <5f274a06-3a9c-7d41-2e4d-9733e4ac6078@arm.com> Date: Fri, 16 Mar 2018 16:19:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180316145511.28362-1-marc.zyngier@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/18 14:55, Marc Zyngier wrote: > Grepping through the dts files, the documentation, and reviewing > patches, one can only notice the use of IRQ_TYPE_NONE in interrupt > specifiers. At least for the GIC, this doesn't mean anything. The > unsuspecting driver will end-up with whatever was there before, and > there is a 50% probability that it is not what it wants. > > I'd love to fix it myself, but I also have a 50% probability of > getting it wrong. In order to make the user aware they are walking on > thin ice, let's add some warnings. Hopefully, they'll be annoying > enough that people will fix their firmware. Croudsourcing debugging... I guess there's also the alternative nuclear option of breaking their build ;) Robin. ----->8----- diff --git a/include/dt-bindings/interrupt-controller/irq.h b/include/dt-bindings/interrupt-controller/irq.h index a8b310555f14..de79af80d01e 100644 --- a/include/dt-bindings/interrupt-controller/irq.h +++ b/include/dt-bindings/interrupt-controller/irq.h @@ -10,7 +10,7 @@ #ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_IRQ_H #define _DT_BINDINGS_INTERRUPT_CONTROLLER_IRQ_H -#define IRQ_TYPE_NONE 0 +#define IRQ_TYPE_NONE "This is nonsense and needs fixing" #define IRQ_TYPE_EDGE_RISING 1 #define IRQ_TYPE_EDGE_FALLING 2 #define IRQ_TYPE_EDGE_BOTH (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)